Bug 230113

Summary:

[ BigSur arm64 EWS ] ASSERTION FAILED: !needsLayout() ./rendering/RenderView.cpp(305) : virtual void WebCore::RenderView::paint(WebCore::PaintInfo &, const WebCore::LayoutPoint &)

Product:

WebKit

Reporter:

ayumi_kojima

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

bfulgham, fpizlo, graouts, mark.lam, sam, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Mac (Apple Silicon)

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=229671
https://bugs.webkit.org/show_bug.cgi?id=230296

Attachments:

Description	Flags
Crash log	none

Description ayumi_kojima 2021-09-09 10:56:46 PDT

svg/animations/animate-elem-14-t-drt.html

Is a flaky crash on macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS.

The flaky crash is not seen in the open source directory: https://results.webkit.org/?suite=layout-tests&test=svg%2Fanimations%2Fanimate-elem-14-t-drt.html

The flaky crash started showing up at https://ews-build.webkit.org/#/builders/60/builds/9286

Result page: https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r434912-9286-rerun/results.html

ASSERTION FAILED: !needsLayout()
./rendering/RenderView.cpp(305) : virtual void WebCore::RenderView::paint(WebCore::PaintInfo &, const WebCore::LayoutPoint &)
1   0x13977b35c WTFCrash
2   0x118a69c20 WebCore::JSCharacterData::createPrototype(JSC::VM&, WebCore::JSDOMGlobalObject&)
3   0x11cf4ea68 WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
4   0x11cde6324 WebCore::RenderLayer::paintBackgroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
5   0x11cde2c7c WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
6   0x11ce03c84 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_24::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const
7   0x11ce03688 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)
8   0x11ce04960 WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
9   0x11c6a76c4 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
10  0x11c769d44 WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
11  0x119f61810 WebCore::PlatformCALayer::drawLayerContents(WebCore::GraphicsContext&, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, unsigned int)
12  0x11c7b01a8 WebCore::TileGrid::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
13  0x11a0e9664 -[WebSimpleLayer drawInContext:]
14  0x198a837ac CABackingStoreUpdate_
15  0x198ae04b4 invocation function for block in CA::Layer::display_()
16  0x198a82a34 -[CALayer _display]
17  0x11a0e93a8 -[WebSimpleLayer display]
18  0x198a81b2c CA::Layer::display_if_needed(CA::Transaction*)
19  0x198badb64 CA::Context::commit_transaction(CA::Transaction*, double, double*)
20  0x198a63ab8 CA::Transaction::commit()
21  0x195138470 __62+[CATransaction(NSCATransaction) NS_setFlushesWithDisplayLink]_block_invoke
22  0x19588d23c ___NSRunLoopObserverCreateWithHandler_block_invoke
23  0x1927cdcc8 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__
24  0x1927cdb14 __CFRunLoopDoObservers
25  0x1927cd05c __CFRunLoopRun
26  0x1927cc5e8 CFRunLoopRunSpecific
27  0x193575688 -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
28  0x193607b70 -[NSRunLoop(NSRunLoop) run]
29  0x192443768 _xpc_objc_main
30  0x192442f94 xpc_main
31  0x1062f5b0c WebKit::XPCServiceMain(int, char const**)
com.apple.WebKit.WebContent.Development terminated (pid 32719) because the process crashed
LEAK: 3 WebPageProxy

Comment 1 ayumi_kojima 2021-09-09 10:57:22 PDT

Created attachment 437761 [details]
Crash log

Comment 2 Radar WebKit Bug Importer 2021-09-09 10:57:51 PDT

<rdar://problem/82933947>

Comment 3 ayumi_kojima 2021-09-09 10:58:12 PDT

Bug 229671 might be related since the crash log seems to be very similar.

Comment 4 ayumi_kojima 2021-09-09 11:02:09 PDT

Marked expectations to speed up EWS https://trac.webkit.org/changeset/282226/webkit

Comment 5 ayumi_kojima 2021-09-10 16:26:58 PDT

I was not able to reproduce the crash using --iterations 1000 --clobber-old-results --exit-after-n-crashes-or-timeouts 1 --force --debug svg/animations/animate-elem-14-t-drt.html

Comment 6 Brent Fulgham 2022-06-23 14:13:28 PDT

We believe this was fixed by https://trac.webkit.org/changeset/291788