Bug 230052

Summary: Add PrivateClickMeasurement daemon
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231817    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Alex Christensen
Reported 2021-09-08 10:02:19 PDT
Add PrivateClickMeasurement daemon
Attachments
Patch (104.39 KB, patch)
2021-09-08 15:59 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (104.40 KB, patch)
2021-09-08 16:39 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (104.26 KB, patch)
2021-09-08 16:46 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (104.27 KB, patch)
2021-09-08 16:57 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (104.01 KB, patch)
2021-09-08 17:08 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (104.40 KB, patch)
2021-09-08 20:59 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (104.49 KB, patch)
2021-09-08 21:04 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (105.76 KB, patch)
2021-09-08 21:21 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (106.56 KB, patch)
2021-09-08 21:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-09-08 15:59:32 PDT
Created attachment 437672 [details] Patch
Alex Christensen
Comment 2 2021-09-08 16:39:26 PDT
Created attachment 437679 [details] Patch
Alex Christensen
Comment 3 2021-09-08 16:46:42 PDT
Created attachment 437681 [details] Patch
Alex Christensen
Comment 4 2021-09-08 16:57:36 PDT
Created attachment 437684 [details] Patch
Alex Christensen
Comment 5 2021-09-08 17:08:19 PDT
Created attachment 437686 [details] Patch
Alex Christensen
Comment 6 2021-09-08 20:59:14 PDT
Created attachment 437704 [details] Patch
Alex Christensen
Comment 7 2021-09-08 21:04:29 PDT
Created attachment 437705 [details] Patch
Alex Christensen
Comment 8 2021-09-08 21:21:04 PDT
Created attachment 437706 [details] Patch
Alex Christensen
Comment 9 2021-09-08 21:55:48 PDT
Created attachment 437709 [details] Patch
Chris Dumez
Comment 10 2021-09-09 10:43:53 PDT
Comment on attachment 437709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437709&action=review > Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementDaemonConnectionCocoa.mm:46 > + ASSERT(RunLoop::isMain()); Is that guaranteed?
Alex Christensen
Comment 11 2021-09-09 10:45:57 PDT
Comment on attachment 437709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437709&action=review >> Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementDaemonConnectionCocoa.mm:46 >> + ASSERT(RunLoop::isMain()); > > Is that guaranteed? It is because we use dispatch_get_main_queue when creating this connection.
EWS
Comment 12 2021-09-09 11:25:50 PDT
Committed r282230 (241514@main): <https://commits.webkit.org/241514@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437709 [details].
Radar WebKit Bug Importer
Comment 13 2021-09-09 11:26:24 PDT
<rdar://problem/82935590>
Note You need to log in before you can comment on or make changes to this bug.