Bug 230015 – Replace PrivateClickMeasurementNetworkLoader::start with an implementation that doesn't need NetworkSession

• Component: New Bugs
• Status: REOPENED

[Alex Christensen]

Replace PrivateClickMeasurementNetworkLoader::start with an implementation that doesn't need NetworkSession

[Alex Christensen]

Created attachment 437541 [details]
Patch

[Alex Christensen]

Created attachment 437544 [details]
Patch

[Alex Christensen]

Created attachment 437546 [details]
Patch

[Alex Christensen]

Created attachment 437552 [details]
Patch

[John Wilander]

Comment on attachment 437546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437546&action=review

We should check that we're not leaving behind an ephemeral, stateless session that is no longer used. I believe we use it for more things but we should make sure.

See inline questions. r=me as long as EWS is happy.

> Source/WebKit/ChangeLog:8
> +        This is needed to run this code in a process that doesn't have NetworkSession, which is a class tied closely to WKWebsiteDataStore.

With this change, do we still have guarantees that PCM will not be enabled in ephemeral sessions?

> Source/WebKit/ChangeLog:11
> +        2. Does not allow redirects.

Did we have this configuration before? I'm for it until we are proven otherwise but I want to keep track of any functional changes.

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementNetworkLoaderCocoa.mm:88
> +        configuration._shouldSkipPreferredClientCertificateLookup = YES;

What does this imply?

[Alex Christensen]

(In reply to John Wilander from comment #5)
> Comment on attachment 437546 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437546&action=review
> 
> We should check that we're not leaving behind an ephemeral, stateless
> session that is no longer used. I believe we use it for more things but we
> should make sure.
> 
> See inline questions. r=me as long as EWS is happy.
> 
> > Source/WebKit/ChangeLog:8
> > +        This is needed to run this code in a process that doesn't have NetworkSession, which is a class tied closely to WKWebsiteDataStore.
> 
> With this change, do we still have guarantees that PCM will not be enabled
> in ephemeral sessions?
Yes, that is currently done in a function named pcmStoreDirectory.

> > Source/WebKit/ChangeLog:11
> > +        2. Does not allow redirects.
> 
> Did we have this configuration before? I'm for it until we are proven
> otherwise but I want to keep track of any functional changes.
Yes, PrivateClickMeasurementNetworkLoader::willSendRedirectedRequest called cancel.

> > Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementNetworkLoaderCocoa.mm:88
> > +        configuration._shouldSkipPreferredClientCertificateLookup = YES;
> 
> What does this imply?
This is what we do for all our sessions in WebKit now.  It makes it so that CFNetwork doesn't look in the keychain for client certificates if the server requests one.

[Alex Christensen]

Created attachment 437561 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r282110

[Radar WebKit Bug Importer]

<rdar://problem/82841918>

[Alex Christensen]

Reopening to attach new patch.

[Alex Christensen]

Created attachment 437576 [details]
Patch

[Alex Christensen]

Removed extra "static" and committed to r282121