Summary: | [build.webkit.org][ews-build.webkit.org] Only try to download from S3 on the production server | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, angelos, ap, clopez, dpino, jbedard, pnormand, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=218439 https://bugs.webkit.org/show_bug.cgi?id=218755 |
||||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2021-09-07 09:39:54 PDT
Created attachment 437517 [details]
Patch
Created attachment 437521 [details]
Patch
Created attachment 437525 [details]
Patch
v2: Add an unit test
Comment on attachment 437525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437525&action=review > Tools/CISupport/build-webkit-org/steps.py:412 > + self.results = SKIPPED Ditto. This line isn't needed. > Tools/CISupport/ews-build/steps.py:2806 > + self.results = SKIPPED This line isn't needed. Better to remove it. I tested in https://ews-build.webkit-uat.org/#/builders/34/builds/41512 that it works without this line. Committed r282100 (241398@main): <https://commits.webkit.org/241398@main> (In reply to Carlos Alberto Lopez Perez from comment #0) > Uploading the built product to S3 is only possible on the official > deployment (since it has the keys, etc) > So on tests deployments we need to find a different way of passing the built > product between workers. > > r269261 implemented this for ews-build.webkit.org and then r269634 > implemented it for build.webkit.org ^^^ just a minor edit, above should say: "" r269248 implemented this for ews-build.webkit.org "" |