Bug 229995

Summary:

TestWebKitAPI.EventAttribution.Basic is extremely flaky on api-ios

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, ayumi_kojima, jbedard, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Aakash Jain 2021-09-07 04:31:06 PDT

TestWebKitAPI.EventAttribution.Basic has become extremely flaky on api-ios EWS since last few days. It is frequently causing false positives on EWS, blaming innocent patches for causing this test failure.

e.g.:
https://ews-build.webkit.org/#/builders/9/builds/53916
https://ews-build.webkit.org/#/builders/9/builds/53850
https://ews-build.webkit.org/#/builders/9/builds/53855
https://ews-build.webkit.org/#/builders/9/builds/53858
https://ews-build.webkit.org/#/builders/9/builds/53871
https://ews-build.webkit.org/#/builders/9/builds/53878
https://ews-build.webkit.org/#/builders/9/builds/53884

Comment 1 Aakash Jain 2021-09-07 04:33:50 PDT

Unfortunately https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.EventAttribution.Basic doesn't have lot of data for iOS release because of Bug 229994.

Comment 2 Aakash Jain 2021-09-07 04:34:31 PDT Comment hidden (obsolete)

Recent changes in were in r281723 and r281779.

Comment 3 Aakash Jain 2021-09-07 04:34:55 PDT

Recent changes in EventAttribution.mm were in r281723 and r281779

Comment 4 Aakash Jain 2021-09-07 04:41:01 PDT

Committed r282079 (241379@main): <https://commits.webkit.org/241379@main>

Comment 5 ayumi_kojima 2021-09-07 09:46:35 PDT

Tried on both iOS 14 simulator and BigSur, but I was not able to reproduce the timeout locally using run-api-tests --iterations 50 --ios-simulator TestWebKitAPI.EventAttribution.Basic --release.

Comment 6 Radar WebKit Bug Importer 2021-09-07 09:47:23 PDT

<rdar://problem/82826500>

Comment 7 Jonathan Bedard 2021-09-07 10:16:37 PDT

(In reply to ayumi_kojima from comment #5)
> Tried on both iOS 14 simulator and BigSur, but I was not able to reproduce
> the timeout locally using run-api-tests --iterations 50 --ios-simulator
> TestWebKitAPI.EventAttribution.Basic --release.

Try just `TestWebKitAPI.EventAttribution`, bet we have some test results poisoning one another.

Comment 8 Alex Christensen 2021-09-07 10:17:27 PDT

I'm looking into this.  I bet adding more tests caused state to be left on disk from one test affecting a future test.

Comment 9 Alex Christensen 2021-09-07 10:49:03 PDT

Created attachment 437531 [details]
Patch

Comment 10 Alex Christensen 2021-09-07 10:51:10 PDT

Created attachment 437533 [details]
Patch

Comment 11 Alex Christensen 2021-09-07 10:54:31 PDT

Created attachment 437534 [details]
Patch

Comment 12 EWS 2021-09-07 11:29:09 PDT

Committed r282102 (241400@main): <https://commits.webkit.org/241400@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437534 [details].

Comment 13 Alex Christensen 2021-09-13 09:38:58 PDT

*** Bug 229852 has been marked as a duplicate of this bug. ***