Bug 229928

Summary: [Win] PlatformWebView::simulateSpacebarKeyPress sends wrong scan code for the space key and Alt key
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2021-09-05 18:28:14 PDT
[Win] PlatformWebView::simulateSpacebarKeyPress sends a wrong scan code for the space key PlatformWebView::simulateSpacebarKeyPress sends 39, but it should be 0x39. PlatformWebView::simulateAltKeyPress send 38, but it should be 0x38. These code were originally added by r69671. The scan codes are defined in WindowsKeyNames.cpp. https://github.com/WebKit/WebKit/blob/1447dba3960bb20229b5caefdcd61a3f9a2bf276/Source/WebCore/platform/win/WindowsKeyNames.cpp#L362,L363 > { 0x0038, "AltLeft"_s }, > { 0x0039, "Space"_s },
Attachments
Patch (3.16 KB, patch)
2021-09-05 18:33 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-09-05 18:33:04 PDT
Created attachment 437372 [details] Patch
Fujii Hironori
Comment 2 2021-09-07 19:12:15 PDT
Comment on attachment 437372 [details] Patch Clearing flags on attachment: 437372 Committed r282124 (241421@main): <https://commits.webkit.org/241421@main>
Fujii Hironori
Comment 3 2021-09-07 19:12:18 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2021-09-07 19:13:15 PDT
<rdar://problem/82850842>
Note You need to log in before you can comment on or make changes to this bug.