Summary: | [Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | annulen, don.olmstead, ews-watchlist, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Fujii Hironori
2021-09-05 18:06:50 PDT
Created attachment 437370 [details]
Patch
Created attachment 437449 [details]
Patch
Comment on attachment 437449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437449&action=review r=me I think this will break the PlayStation without the implementation being there as well. > Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:29 > +#if !PLATFORM(GTK) && !PLATFORM(WPE) This should probably be #if PLATFORM(COCOA) || PLATFORM(WIN) > Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:72 > +#endif // !PLATFORM(GTK) && !PLATFORM(WPE) Same Created attachment 437579 [details]
Patch for landing
Comment on attachment 437579 [details] Patch for landing Clearing flags on attachment: 437579 Committed r282128 (241425@main): <https://commits.webkit.org/241425@main> All reviewed patches have been landed. Closing bug. |