Bug 229927

Summary: [Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, don.olmstead, ews-watchlist, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Fujii Hironori
Reported 2021-09-05 18:06:50 PDT
[Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing TestWebKitAPI::Util::isKeyDown is not implemented
Attachments
Patch (1.98 KB, patch)
2021-09-05 18:09 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (2.68 KB, patch)
2021-09-06 21:07 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.74 KB, patch)
2021-09-07 19:18 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-09-05 18:09:16 PDT
Created attachment 437370 [details] Patch
Fujii Hironori
Comment 2 2021-09-06 21:07:39 PDT
Created attachment 437449 [details] Patch
Don Olmstead
Comment 3 2021-09-07 18:20:03 PDT
Comment on attachment 437449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437449&action=review r=me I think this will break the PlayStation without the implementation being there as well. > Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:29 > +#if !PLATFORM(GTK) && !PLATFORM(WPE) This should probably be #if PLATFORM(COCOA) || PLATFORM(WIN) > Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:72 > +#endif // !PLATFORM(GTK) && !PLATFORM(WPE) Same
Fujii Hironori
Comment 4 2021-09-07 19:18:32 PDT
Created attachment 437579 [details] Patch for landing
Fujii Hironori
Comment 5 2021-09-07 21:57:53 PDT
Comment on attachment 437579 [details] Patch for landing Clearing flags on attachment: 437579 Committed r282128 (241425@main): <https://commits.webkit.org/241425@main>
Fujii Hironori
Comment 6 2021-09-07 21:57:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2021-09-07 21:58:22 PDT
<rdar://problem/82855497>
Note You need to log in before you can comment on or make changes to this bug.