Bug 229920

Summary: [GStreamer] Enable H265 codec
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Xabier Rodríguez Calvar
Reported 2021-09-05 07:09:44 PDT
[GStreamer] Enable H265 codec
Attachments
Patch (3.39 KB, patch)
2021-09-05 07:13 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (6.05 KB, patch)
2021-09-09 03:19 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (6.93 KB, patch)
2021-09-09 03:45 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (6.94 KB, patch)
2021-09-09 06:21 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (7.82 KB, patch)
2021-09-10 01:08 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2021-09-05 07:13:48 PDT
Created attachment 437358 [details] Patch
Philippe Normand
Comment 2 2021-09-08 00:55:18 PDT
Comment on attachment 437358 [details] Patch LGTM but can you add a layout test please? You can find inspiration in the existing media/media-can-play* tests.
Xabier Rodríguez Calvar
Comment 3 2021-09-09 03:19:15 PDT
Created attachment 437726 [details] Patch
Xabier Rodríguez Calvar
Comment 4 2021-09-09 03:45:16 PDT
Created attachment 437728 [details] Patch
Philippe Normand
Comment 5 2021-09-09 04:36:58 PDT
Comment on attachment 437728 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437728&action=review > LayoutTests/platform/mac/media/media-can-play-h265-video-actual.txt:2 > +Test HTMLMediaElement canPlayType() method with multiple video mpeg4 MIME types with H265 codecs. This file is mis-named, should be -expected not -actual
Xabier Rodríguez Calvar
Comment 6 2021-09-09 06:21:39 PDT
Created attachment 437738 [details] Patch
Xabier Rodríguez Calvar
Comment 7 2021-09-09 06:22:00 PDT
(In reply to Philippe Normand from comment #5) > Comment on attachment 437728 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=437728&action=review > > > LayoutTests/platform/mac/media/media-can-play-h265-video-actual.txt:2 > > +Test HTMLMediaElement canPlayType() method with multiple video mpeg4 MIME types with H265 codecs. > > This file is mis-named, should be -expected not -actual yep.
Xabier Rodríguez Calvar
Comment 8 2021-09-10 01:08:07 PDT
Created attachment 437850 [details] Patch
EWS
Comment 9 2021-09-14 00:46:43 PDT
Committed r282382 (241644@main): <https://commits.webkit.org/241644@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437850 [details].
Radar WebKit Bug Importer
Comment 10 2021-09-14 00:47:16 PDT
<rdar://problem/83091462>
Note You need to log in before you can comment on or make changes to this bug.