Bug 229920

Summary: [GStreamer] Enable H265 codec
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Xabier Rodríguez Calvar 2021-09-05 07:09:44 PDT 
[GStreamer] Enable H265 codec
Comment 1 Xabier Rodríguez Calvar 2021-09-05 07:13:48 PDT 
Created attachment 437358 [details]
Patch
Comment 2 Philippe Normand 2021-09-08 00:55:18 PDT 
Comment on attachment 437358 [details]
Patch

LGTM but can you add a layout test please? You can find inspiration in the existing media/media-can-play* tests.
Comment 3 Xabier Rodríguez Calvar 2021-09-09 03:19:15 PDT 
Created attachment 437726 [details]
Patch
Comment 4 Xabier Rodríguez Calvar 2021-09-09 03:45:16 PDT 
Created attachment 437728 [details]
Patch
Comment 5 Philippe Normand 2021-09-09 04:36:58 PDT 
Comment on attachment 437728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437728&action=review

> LayoutTests/platform/mac/media/media-can-play-h265-video-actual.txt:2
> +Test HTMLMediaElement canPlayType() method with multiple video mpeg4 MIME types with H265 codecs.

This file is mis-named, should be -expected not -actual
Comment 6 Xabier Rodríguez Calvar 2021-09-09 06:21:39 PDT 
Created attachment 437738 [details]
Patch
Comment 7 Xabier Rodríguez Calvar 2021-09-09 06:22:00 PDT 
(In reply to Philippe Normand from comment #5)
> Comment on attachment 437728 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437728&action=review
> 
> > LayoutTests/platform/mac/media/media-can-play-h265-video-actual.txt:2
> > +Test HTMLMediaElement canPlayType() method with multiple video mpeg4 MIME types with H265 codecs.
> 
> This file is mis-named, should be -expected not -actual

yep.
Comment 8 Xabier Rodríguez Calvar 2021-09-10 01:08:07 PDT 
Created attachment 437850 [details]
Patch
Comment 9 EWS 2021-09-14 00:46:43 PDT 
Committed r282382 (241644@main): <https://commits.webkit.org/241644@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437850 [details].
Comment 10 Radar WebKit Bug Importer 2021-09-14 00:47:16 PDT 
<rdar://problem/83091462>