Bug 229918

Summary: [Flatpak SDK] Update to FDO 21.08
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229919    
Attachments:
Description Flags
Patch clopez: review+, ews-feeder: commit-queue-

Philippe Normand
Reported 2021-09-05 02:41:54 PDT
Highlights: - GCC 11.1 - clang 12 - Mesa as extension again - Ruby 3 (as side effect we now ship the webrick gem) - Our SDK branch number is now the same as FDO SDK - Some of our recipes no longer needed because maintained in FDO SDK
Attachments
Patch (132.70 KB, patch)
2021-09-05 03:53 PDT, Philippe Normand 		clopez: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-09-05 03:53:43 PDT
Created attachment 437354 [details] Patch
Philippe Normand
Comment 2 2021-09-05 04:28:30 PDT
Ah another notable update, ICU 67.1 -> 69.1 seems to break test262: ---------------NEW FAILING TESTS SUMMARY--------------- FAIL test/intl402/Intl/getCanonicalLocales/preferred-grandfathered.js (default) Full Output: Exception: Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true FAIL test/intl402/Intl/getCanonicalLocales/preferred-grandfathered.js (strict mode) Full Output: Exception: Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true FAIL test/intl402/Locale/extensions-grandfathered.js (default) Full Output: Exception: Test262Error: Expected SameValue(«fr-Cyrl-FR-gaulish-u-nu-latn», «fr-Cyrl-FR-u-nu-latn») to be true FAIL test/intl402/Locale/extensions-grandfathered.js (strict mode) Full Output: Exception: Test262Error: Expected SameValue(«fr-Cyrl-FR-gaulish-u-nu-latn», «fr-Cyrl-FR-u-nu-latn») to be true FAIL test/intl402/Locale/getters-grandfathered.js (default) Full Output: Exception: Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true FAIL test/intl402/Locale/getters-grandfathered.js (strict mode) Full Output: Exception: Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true FAIL test/intl402/Locale/likely-subtags-grandfathered.js (default) Full Output: Exception: Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true FAIL test/intl402/Locale/likely-subtags-grandfathered.js (strict mode) Full Output: Exception: Test262Error: Expected SameValue(«cel-gaulish», «xtg») to be true ---------------NEW PASSING TESTS SUMMARY--------------- PASS test/intl402/DateTimeFormat/prototype/formatRange/en-US.js (default) PASS test/intl402/DateTimeFormat/prototype/formatRange/en-US.js (strict mode) PASS test/intl402/DateTimeFormat/prototype/formatRange/fractionalSecondDigits.js (default) PASS test/intl402/DateTimeFormat/prototype/formatRange/fractionalSecondDigits.js (strict mode) PASS test/intl402/Intl/getCanonicalLocales/non-iana-canon.js (default) PASS test/intl402/Intl/getCanonicalLocales/non-iana-canon.js (strict mode) PASS test/intl402/Locale/prototype/minimize/removing-likely-subtags-first-adds-likely-subtags.js (default) PASS test/intl402/Locale/prototype/minimize/removing-likely-subtags-first-adds-likely-subtags.js (strict mode) ---------------------------------------------------------
Philippe Normand
Comment 3 2021-09-05 04:47:19 PDT
JSC intl-locale failures: executableAllocationFuzz.yaml/executableAllocationFuzz/v8-raytrace.js.executable-allocation-fuzz-default: Executable allocation fuzz testing not supported by jsc binary. executableAllocationFuzz.yaml/executableAllocationFuzz/v8-raytrace.js.executable-allocation-fuzz-no-cjit: Executable allocation fuzz testing not supported by jsc binary. stress/intl-locale.js.default: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.default: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.default: global code@intl-locale.js:155:9 stress/intl-locale.js.mini-mode: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.mini-mode: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.mini-mode: global code@intl-locale.js:155:9 stress/intl-locale.js.no-llint: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.no-llint: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.no-llint: global code@intl-locale.js:155:9 stress/intl-locale.js.mini-mode: ERROR: Unexpected exit code: 3 stress/intl-locale.js.default: ERROR: Unexpected exit code: 3 stress/intl-locale.js.no-llint: ERROR: Unexpected exit code: 3 stress/intl-locale.js.bytecode-cache: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.bytecode-cache: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.bytecode-cache: global code@intl-locale.js:155:9 stress/intl-locale.js.bytecode-cache: Command '../../.vm/JavaScriptCore.framework/Helpers/jsc intl-locale.js --useFTLJIT=false --useFunctionDotArguments=true --validateExceptionChecks=true --useDollarVM=true --maxPerThreadStackUsage=1572864 --useFTLJIT=true' failed stress/intl-locale.js.no-cjit-validate-phases: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.no-cjit-validate-phases: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.no-cjit-validate-phases: global code@intl-locale.js:155:9 stress/intl-locale.js.bytecode-cache: ERROR: Unexpected exit code: 3 stress/intl-locale.js.no-cjit-validate-phases: ERROR: Unexpected exit code: 3 stress/intl-locale.js.no-ftl: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.no-ftl: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.no-ftl: global code@intl-locale.js:155:9 stress/intl-locale.js.eager-jettison-no-cjit: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.eager-jettison-no-cjit: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.eager-jettison-no-cjit: global code@intl-locale.js:155:9 stress/intl-locale.js.no-ftl: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-no-cjit-small-pool: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.ftl-no-cjit-small-pool: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.ftl-no-cjit-small-pool: global code@intl-locale.js:155:9 stress/intl-locale.js.eager-jettison-no-cjit: ERROR: Unexpected exit code: 3 stress/intl-locale.js.no-cjit-collect-continuously: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.no-cjit-collect-continuously: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.no-cjit-collect-continuously: global code@intl-locale.js:155:9 stress/intl-locale.js.dfg-eager-no-cjit-validate: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.dfg-eager-no-cjit-validate: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.dfg-eager-no-cjit-validate: global code@intl-locale.js:155:9 stress/intl-locale.js.ftl-no-cjit-small-pool: ERROR: Unexpected exit code: 3 stress/intl-locale.js.no-cjit-collect-continuously: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-no-cjit-b3o0: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.ftl-no-cjit-b3o0: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.ftl-no-cjit-b3o0: global code@intl-locale.js:155:9 stress/intl-locale.js.dfg-eager: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.dfg-eager: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.dfg-eager: global code@intl-locale.js:155:9 stress/intl-locale.js.dfg-eager-no-cjit-validate: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-no-cjit-validate-sampling-profiler: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.ftl-no-cjit-validate-sampling-profiler: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.ftl-no-cjit-validate-sampling-profiler: global code@intl-locale.js:155:9 stress/intl-locale.js.ftl-no-cjit-b3o0: ERROR: Unexpected exit code: 3 stress/intl-locale.js.dfg-eager: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-no-cjit-validate-sampling-profiler: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-eager: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.ftl-eager: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.ftl-eager: global code@intl-locale.js:155:9 stress/intl-locale.js.ftl-eager: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-no-cjit-no-inline-validate: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.ftl-no-cjit-no-inline-validate: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.ftl-no-cjit-no-inline-validate: global code@intl-locale.js:155:9 stress/intl-locale.js.ftl-no-cjit-no-inline-validate: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-no-cjit-no-put-stack-validate: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.ftl-no-cjit-no-put-stack-validate: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.ftl-no-cjit-no-put-stack-validate: global code@intl-locale.js:155:9 stress/intl-locale.js.ftl-no-cjit-no-put-stack-validate: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-eager-no-cjit: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.ftl-eager-no-cjit: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.ftl-eager-no-cjit: global code@intl-locale.js:155:9 stress/intl-locale.js.ftl-eager-no-cjit: ERROR: Unexpected exit code: 3 stress/intl-locale.js.ftl-eager-no-cjit-b3o1: Exception: Error: expected xtg-Arab-u-nu-gujr-x-cel-gaulish but got cel-Arab-gaulish-u-nu-gujr stress/intl-locale.js.ftl-eager-no-cjit-b3o1: shouldBe@intl-locale.js:3:24 stress/intl-locale.js.ftl-eager-no-cjit-b3o1: global code@intl-locale.js:155:9 stress/intl-locale.js.ftl-eager-no-cjit-b3o1: ERROR: Unexpected exit code: 3
Carlos Alberto Lopez Perez
Comment 4 2021-09-05 14:32:40 PDT
Comment on attachment 437354 [details] Patch Patch looks fine, but this kind of upgrades are always very likely to cause unexpected results on layout tests.. please try to re-baseline and/or mark expected failures results when landing. Thanks
Philippe Normand
Comment 5 2021-09-06 00:16:08 PDT
Right. This patch affects only the SDK recipes, the runtime is not affected. Rebaselines/etc will be handled through bug 229919
Philippe Normand
Comment 6 2021-09-11 07:03:30 PDT
Committed r282308 (241580@main): <https://commits.webkit.org/241580@main>
Note You need to log in before you can comment on or make changes to this bug.