Bug 229885

Summary: [macCatalyst] Support photo picker and camera actions for file inputs
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: NEW    
Severity: Normal CC: cdumez, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
thorton: review+, ews-feeder: commit-queue-
Patch for landing none

Aditya Keerthi
Reported 2021-09-03 12:31:12 PDT
iOS supports three actions for media-accepting file inputs: 1. Choose Photo or Video 2. Take Photo or Video 3. Choose File macCatalyst currently only supports (3) – we should add support for (1) and (2).
Attachments
Patch (4.06 KB, patch)
2021-09-03 12:40 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2021-09-03 13:00 PDT, Aditya Keerthi 		thorton: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (3.98 KB, patch)
2021-09-03 13:34 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2021-09-03 12:40:22 PDT
Created attachment 437298 [details] Patch
Aditya Keerthi
Comment 2 2021-09-03 12:44:21 PDT
rdar://49961589
Aditya Keerthi
Comment 3 2021-09-03 13:00:13 PDT
Created attachment 437304 [details] Patch
Tim Horton
Comment 4 2021-09-03 13:08:23 PDT
Comment on attachment 437304 [details] Patch It seems slightly odd to me that we would make macCatalyst WebKit and macOS WebKit do different things when you click a file input, but I don't know if that means "macOS WebKit should get an image picker" or "macCatalyst WebKit should just go straight to NSOpenPanel". Regardless, that should be an explicit decision instead of a random ifdef about missing API, so I guess this is a change in a good /direction/.
Aditya Keerthi
Comment 5 2021-09-03 13:34:43 PDT
Created attachment 437306 [details] Patch for landing
Aditya Keerthi
Comment 6 2021-09-03 13:35:39 PDT
(In reply to Tim Horton from comment #4) > Comment on attachment 437304 [details] > Patch > > It seems slightly odd to me that we would make macCatalyst WebKit and macOS > WebKit do different things when you click a file input, but I don't know if > that means "macOS WebKit should get an image picker" or "macCatalyst WebKit > should just go straight to NSOpenPanel". Regardless, that should be an > explicit decision instead of a random ifdef about missing API, so I guess > this is a change in a good /direction/. Thanks for the review! I will discuss with more Catalyst folks prior to landing.
Note You need to log in before you can comment on or make changes to this bug.