Bug 229877

Summary: REGRESSION (r281981): [iOS, BigSur+] webrtc/datachannel/getStats-no-prflx-remote-candidate.html is a flaky timeout
Product: WebKit Reporter: Eric Hutchison <ehutchison>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ayumi_kojima, ehutchison, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230003
https://bugs.webkit.org/show_bug.cgi?id=229700
Attachments:
Description Flags
Patch
none
Patch none

Eric Hutchison
Reported 2021-09-03 10:04:42 PDT
webrtc/datachannel/getStats-no-prflx-remote-candidate.html is a flaky timeout on iOS and BigSur+. History: https://results.webkit.org/?suite=layout-tests&test=webrtc%2Fdatachannel%2FgetStats-no-prflx-remote-candidate.html Results: https://build.webkit.org/results/Apple-BigSur-Release-WK1-Tests/r281995%20(5068)/results.html Diff: --- /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/webrtc/datachannel/getStats-no-prflx-remote-candidate-expected.txt +++ /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/webrtc/datachannel/getStats-no-prflx-remote-candidate-actual.txt @@ -1,3 +1,2 @@ +FAIL: Timed out waiting for notifyDone to be called -PASS Make sure remote peer reflexive candidates are not exposed in stats -
Attachments
Patch (1.49 KB, patch)
2021-09-16 01:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2021-09-16 08:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-09-03 10:05:22 PDT
<rdar://problem/82728080>
ayumi_kojima
Comment 2 2021-09-07 12:03:39 PDT
The timeout is showing up on EWS as a flaky test. Updated test expectations while investigating to speed up EWS: https://trac.webkit.org/changeset/282104/webkit
youenn fablet
Comment 3 2021-09-08 00:07:24 PDT
https://bugs.webkit.org/show_bug.cgi?id=230003 might help fixing this.
Ryan Haddad
Comment 4 2021-09-09 15:30:28 PDT
We now see: --- /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/webrtc/datachannel/getStats-no-prflx-remote-candidate-expected.txt +++ /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/webrtc/datachannel/getStats-no-prflx-remote-candidate-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: Unhandled Promise Rejection: localDataChannelPromise -PASS Make sure remote peer reflexive candidates are not exposed in stats +FAIL Make sure remote peer reflexive candidates are not exposed in stats
Ryan Haddad
Comment 5 2021-09-09 15:31:44 PDT
The timeouts initially started with https://trac.webkit.org/changeset/281981/webkit
ayumi_kojima
Comment 6 2021-09-14 09:51:17 PDT
Marked test expectations to pass/ fail for Mac-wk1 and removed pass/timeout from iOS-wk2 and Mac-wk2 because the test is no longer timing out: https://trac.webkit.org/changeset/282394/webkit
youenn fablet
Comment 7 2021-09-16 01:15:43 PDT
Created attachment 438327 [details] Patch
EWS
Comment 8 2021-09-16 04:56:37 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-connectionState.https.html
youenn fablet
Comment 9 2021-09-16 08:30:47 PDT
Created attachment 438353 [details] Patch
EWS
Comment 10 2021-09-16 11:35:59 PDT
Committed r282566 (241754@main): <https://commits.webkit.org/241754@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438353 [details].
Note You need to log in before you can comment on or make changes to this bug.