Bug 229873

Summary:

Drop calls to testRunner.setCloseRemainingWindowsWhenComplete() from layout tests

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, eric.carlson, ews-watchlist, glenn, jbedard, jer.noble, mkwst, philipj, sam, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=229881

Bug Depends on:

229838

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2021-09-03 08:42:37 PDT

Drop calls to testRunner.setCloseRemainingWindowsWhenComplete() from layout tests, as it is a no-op.

Comment 1 Chris Dumez 2021-09-03 08:44:22 PDT

Created attachment 437275 [details]
Patch

Comment 2 Sam Weinig 2021-09-03 09:36:32 PDT

Nice. Thanks!

Comment 3 EWS 2021-09-03 09:42:07 PDT

Committed r282004 (241311@main): <https://commits.webkit.org/241311@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437275 [details].

Comment 4 Radar WebKit Bug Importer 2021-09-03 09:43:19 PDT

<rdar://problem/82727180>

Comment 5 Alexey Proskuryakov 2021-09-03 10:15:12 PDT

Chris, why did you land despite EWS being red?

Comment 6 Chris Dumez 2021-09-03 10:16:05 PDT

(In reply to Alexey Proskuryakov from comment #5)
> Chris, why did you land despite EWS being red?

Those failures cannot be caused by my patch as my patch is a no-op.