Bug 229870

Summary: Fix race in RemoteRenderingBackend::allowsExitUnderMemoryPressure()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, kkinnunen, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=238558
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2021-09-03 08:13:42 PDT 
Fix race in RemoteRenderingBackend::allowsExitUnderMemoryPressure().
Comment 1 Chris Dumez 2021-09-03 08:13:55 PDT 
<rdar://82459484>
Comment 2 Chris Dumez 2021-09-03 08:16:06 PDT 
Created attachment 437271 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2021-09-03 11:26:12 PDT 
Comment on attachment 437271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437271&action=review

> Source/WebKit/ChangeLog:9
> +        RemoteRenderingBackend::m_remoteResourceCache should can only be used safely from RemoteRenderingBackend's work queue.

Nit typo:  "should can" => "can".
Comment 4 Chris Dumez 2021-09-03 11:27:57 PDT 
Created attachment 437287 [details]
Patch
Comment 5 EWS 2021-09-03 12:11:32 PDT 
Committed r282011 (241317@main): <https://commits.webkit.org/241317@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437287 [details].
Comment 6 Chris Dumez 2021-09-17 14:20:08 PDT 
Reverted r282011 for reason:

This causes GPUProcess main thread hangs on memory pressure

Committed r282693 (241830@main): <https://commits.webkit.org/241830@main>
Comment 7 Chris Dumez 2021-09-20 08:45:53 PDT 
Created attachment 438683 [details]
Patch
Comment 8 EWS 2021-09-20 10:12:45 PDT 
Committed r282754 (241891@main): <https://commits.webkit.org/241891@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438683 [details].