Summary: | [webkitpy] WrappedPopen breaks process returncode | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=201826 https://bugs.webkit.org/show_bug.cgi?id=229758 |
||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2021-09-02 12:42:43 PDT
Created attachment 437186 [details]
Patch
(In reply to Jonathan Bedard from comment #1) > Created attachment 437186 [details] > Patch I suspect this will fix the problem, although I'm a bit unclear which script can cause this. This fixes it indeed, thanks. I was trying here to instead of wrapping the object to add the __exit__ and __enter__ methods to the Popen class directly, but for some unknown reason then when you try to use the usual "with popen_object:" it doesn't like this methods added via setattr() and complains about missing __exit__ Committed r281952 (241259@main): <https://commits.webkit.org/241259@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437186 [details]. |