Bug 22980

Summary:

WebCore uses more thread specific keys than it really needs

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	darin: review+

Alexey Proskuryakov

Reported 2008-12-23 10:57:15 PST

We should consolidate all ThreadSpecific objects into a single structure.

Attachments
proposed patch (29.14 KB, patch) 2008-12-23 12:47 PST, Alexey Proskuryakov	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2008-12-23 12:47:15 PST

Created attachment 26229 [details] proposed patch

Darin Adler

Comment 2 2008-12-23 13:07:12 PST

Comment on attachment 26229 [details] proposed patch > +#if PLATFORM(MAC) > + delete m_cachedConverterTEC; > +#endif > +#if USE(ICU_UNICODE) > + delete m_cachedConverterICU; > +#endif > + > + delete m_eventNames; > + delete m_atomicStringTable; > + > + ASSERT(m_emptyString->hasOneRef()); > + delete m_emptyString; > +} Why not use an OwnPtr? r=me

Alexey Proskuryakov

Comment 3 2008-12-23 23:48:25 PST

Committed revision 39465. With OwnPtr, I wouldn't be able to assert m_emptyString->hasOneRef(), which is a rather important check.

Note You need to log in before you can comment on or make changes to this bug.