Bug 229781 – Leak of VTImageRotationSessionRef (176 bytes) in com.apple.WebKit.GPU.Development process

• Component: Media
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Leak of VTImageRotationSessionRef (176 bytes) in com.apple.WebKit.GPU.Development process.

STACK OF 1 INSTANCE OF 'ROOT LEAK: <VTImageRotationSession>':
21  com.apple.WebKit.GPU.Development        0x102b79000 0x102b79000 + 0
19  dyld                                  0x10902d4d5 start + 421
18  WebKit                                0x104f6ca30 WebKit::XPCServiceMain(int, char const**) + 137  XPCServiceMain.mm:243
17  libxpc.dylib                       0x7ff80766dc22 xpc_main + 99
16  libxpc.dylib                       0x7ff80766e233 _xpc_objc_main + 825
15  com.apple.Foundation               0x7ff8087f6a03 -[NSRunLoop(NSRunLoop) run] + 76
14  com.apple.Foundation               0x7ff80876c66e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 216
13  com.apple.CoreFoundation           0x7ff8079e1dd9 CFRunLoopRunSpecific + 567
12  com.apple.CoreFoundation           0x7ff8079e282f __CFRunLoopRun + 897
11  com.apple.CoreFoundation           0x7ff8079e3e13 __CFRunLoopDoSources0 + 242
10  com.apple.CoreFoundation           0x7ff8079e40a0 __CFRunLoopDoSource0 + 180
9   com.apple.CoreFoundation           0x7ff8079e4138 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
8   JavaScriptCore                        0x10adcc1c2 WTF::RunLoop::performWork(void*) + 34  RunLoopCF.cpp:47
7   JavaScriptCore                        0x10adcb8ef WTF::RunLoop::performWork() + 431  RunLoop.cpp:134
6   WebCore                               0x10da46a54 WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged() + 1476  MediaPlayerPrivateAVFoundationObjC.mm:2108
5   WebCore                               0x10da48aa5 WebCore::MediaPlayerPrivateAVFoundationObjC::updateRotationSession() + 773  MediaPlayerPrivateAVFoundationObjC.mm:2200
4   WebCore                               0x10d9e5bc0 WebCore::ImageRotationSessionVT::ImageRotationSessionVT(WebCore::AffineTransform&&, WebCore::FloatSize, WebCore::ImageRotationSessionVT::IsCGImageCompatible) + 128  ImageRotationSessionVT.mm:0
3   WebCore                               0x10d9e5d2c WebCore::ImageRotationSessionVT::initialize(WebCore::ImageRotationSessionVT::RotationProperties const&, WebCore::FloatSize, WebCore::ImageRotationSessionVT::IsCGImageCompatible) + 236  ImageRotationSessionVT.mm:86
2   com.apple.VideoToolbox             0x7ff8142f4930 VTImageRotationSessionCreate + 143
1   com.apple.CoreFoundation           0x7ff807967d90 _CFRuntimeCreateInstance + 580
0   libsystem_malloc.dylib             0x7ff807757d52 _malloc_zone_malloc + 249 
====
    2 (176 bytes) ROOT LEAK: <VTImageRotationSession 0x7fdbbe949ca0> [144]
       1 (32 bytes) <NSMutableDictionary 0x7fdbbe9415c0> [32]

[David Kilzer (:ddkilzer)]

<rdar://problem/82651897>

[David Kilzer (:ddkilzer)]

Missing an adoptCF() in Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm:

    VTImageRotationSessionRef rawRotationSession = nullptr;
    VTImageRotationSessionCreate(kCFAllocatorDefault, m_rotationProperties.angle, &rawRotationSession);
    m_rotationSession = rawRotationSession;

[David Kilzer (:ddkilzer)]

Created attachment 437089 [details]
Patch v1

[David Kilzer (:ddkilzer)]

The mac-debug-wk1 failures are not related to this patch.

See:  <https://trac.webkit.org/changeset/281934/webkit>

[EWS]

Committed r281950 (241257@main): <https://commits.webkit.org/241257@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437089 [details].