Implement atan, acos, asin, atan2 calc functions

• Component: New Bugs
• Status: RESOLVED FIXED

[Nikos Mouchtaris]

Implement atan, acos, asin, atan2 calc functions

[Nikos Mouchtaris]

Created attachment 437076 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/82837327>

[Nikos Mouchtaris]

Created attachment 438279 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Nikos Mouchtaris]

Created attachment 438298 [details]
Patch

[Nikos Mouchtaris]

Created attachment 438299 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 438299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438299&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Tests: imported/w3c/web-platform-tests/css/css-values/acos-asin-atan-atan2-computed.html

Words here please (like a spec link etc).

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:490
> +
>  

Too many blank lines.

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:-441
> -        return;

Is this removal significant?

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:630
> +        auto newChild = CSSCalcPrimitiveValueNode::create(CSSPrimitiveValue::create(resolvedValue, CSSUnitType::CSS_DEG));

Is it CSS_DEG because the spec says that degrees are the canonical angle unit?

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:1133
> +        return rad2deg(std::asin(children[0]));

Maybe link to the part of the spec that explains why returning angles in degrees is correct.

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:1138
> +        return rad2deg(std::asin(children[0]));

acts, not asin? Why did tests not catch this.

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:1143
> +        return rad2deg(std::asin(children[0]));

asin -> atan? Again, where is the test coverage.

[Nikos Mouchtaris]

Created attachment 438772 [details]
asin,acos,atan,atan2

[Nikos Mouchtaris]

Created attachment 438846 [details]
inverse trig functions

[Nikos Mouchtaris]

Created attachment 438855 [details]
inverse trig functions

[Nikos Mouchtaris]

Created attachment 438863 [details]
inverse trig functions

[EWS]

Committed r283013 (242078@main): <https://commits.webkit.org/242078@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438863 [details].