Summary: | Enable WebRTC relay for SafariViewController | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, eric.carlson, ews-watchlist, sam, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
youenn fablet
2021-09-01 13:24:47 PDT
Created attachment 437064 [details]
Patch
Created attachment 437133 [details]
Patch
Created attachment 437134 [details]
Patch
Created attachment 437138 [details]
Patch
Comment on attachment 437138 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437138&action=review > Source/WebKit/ChangeLog:11 > + Use source application bundle identifier instead of attributed bundle identifier for nw_parameters_set_source_application_by_bundle_id. > + Use attributed bundle identifier for nw_parameters_set_attributed_bundle_identifier. > + Make sure to not set token data in case application bundle identifier is available. > + Introduce a helper routine to share more code between UDP and TCP sockets. Please add an explanation as to why this fixes the bug. Please explain what this has to do with "Enable WebRTC relay for SafariViewController". > Source/WebKit/ChangeLog:13 > + Manually tested. Please add an explanation as to why this can't be tested in an automated fashion. Anything without automated testing is prone to regression. > > Source/WebKit/ChangeLog:11 > > + Use source application bundle identifier instead of attributed bundle identifier for nw_parameters_set_source_application_by_bundle_id. > > + Use attributed bundle identifier for nw_parameters_set_attributed_bundle_identifier. > > + Make sure to not set token data in case application bundle identifier is available. > > + Introduce a helper routine to share more code between UDP and TCP sockets. > > Please add an explanation as to why this fixes the bug. Please explain what > this has to do with "Enable WebRTC relay for SafariViewController". Sure, relay is decided by NW layer upon source application, which can either be a bundle id or a token. > > Source/WebKit/ChangeLog:13 > > + Manually tested. > > Please add an explanation as to why this can't be tested in an automated > fashion. Anything without automated testing is prone to regression. Such testing would require access to relays from our testing bots. Plus the right source application bundle. Created attachment 437245 [details]
Patch for landing
Committed r281982 (241289@main): <https://commits.webkit.org/241289@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437245 [details]. |