Bug 229757

Summary:

Implement libwebrtc network manager GetMdnsResponder

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, cdumez, crzwdjk, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=230021

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Rebasing	none
Rebasing	none

youenn fablet

Reported 2021-09-01 03:35:03 PDT

Implement libwebrtc network manager GetMdnsResponder. This allows to integrate mDNS handling directly in libwebrtc backend

Attachments
Patch (81.29 KB, patch) 2021-09-01 04:42 PDT, youenn fablet	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (82.67 KB, patch) 2021-09-01 04:55 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (81.08 KB, patch) 2021-09-01 04:59 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (81.44 KB, patch) 2021-09-01 06:21 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (81.72 KB, patch) 2021-09-01 06:28 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (81.75 KB, patch) 2021-09-01 06:47 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (81.79 KB, patch) 2021-09-01 07:05 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (82.85 KB, patch) 2021-09-01 11:31 PDT, youenn fablet	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (82.83 KB, patch) 2021-09-01 13:23 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (85.70 KB, patch) 2021-09-02 00:00 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Rebasing (85.81 KB, patch) 2021-09-05 23:39 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Rebasing (85.81 KB, patch) 2021-09-05 23:40 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2021-09-01 04:42:25 PDT

Created attachment 437014 [details] Patch

youenn fablet

Comment 2 2021-09-01 04:55:29 PDT

Created attachment 437016 [details] Patch

youenn fablet

Comment 3 2021-09-01 04:59:37 PDT

Created attachment 437017 [details] Patch

youenn fablet

Comment 4 2021-09-01 06:21:00 PDT

Created attachment 437023 [details] Patch

youenn fablet

Comment 5 2021-09-01 06:28:45 PDT

Created attachment 437024 [details] Patch

youenn fablet

Comment 6 2021-09-01 06:47:25 PDT

Created attachment 437025 [details] Patch

youenn fablet

Comment 7 2021-09-01 07:05:45 PDT

Created attachment 437026 [details] Patch

youenn fablet

Comment 8 2021-09-01 11:31:55 PDT

Created attachment 437046 [details] Patch

youenn fablet

Comment 9 2021-09-01 13:23:48 PDT

Created attachment 437063 [details] Patch

youenn fablet

Comment 10 2021-09-02 00:00:42 PDT

Created attachment 437117 [details] Patch

youenn fablet

Comment 11 2021-09-05 23:39:14 PDT

Created attachment 437388 [details] Rebasing

youenn fablet

Comment 12 2021-09-05 23:40:41 PDT

Created attachment 437389 [details] Rebasing

EWS

Comment 13 2021-09-06 01:49:10 PDT

Committed r282054 (241354@main): <https://commits.webkit.org/241354@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437389 [details].

Radar WebKit Bug Importer

Comment 14 2021-09-06 01:50:21 PDT

<rdar://problem/82786787>

Arcady Goldmints-Orlov

Comment 15 2021-09-07 13:03:29 PDT

Looks like this has caused the test webrtc/ephemeral-certificates-and-cnames.html to become flaky, I think on all platforms. When it fails on GTK it fails like this: --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/webrtc/ephemeral-certificates-and-cnames-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/webrtc/ephemeral-certificates-and-cnames-actual.txt @@ -1,3 +1,7 @@ +CONSOLE MESSAGE: addIceCandidate error: OperationError: Error processing ICE candidate +CONSOLE MESSAGE: Unhandled Promise Rejection: Error: assert_unreached: Reached unreachable code + +Harness Error (FAIL), message = assert_unreached: Reached unreachable code PASS Ensuring certificates and cnames are ephemerals

youenn fablet

Comment 16 2021-09-08 00:08:59 PDT

(In reply to Arcady Goldmints-Orlov from comment #15) > Looks like this has caused the test > webrtc/ephemeral-certificates-and-cnames.html to become flaky, I think on > all platforms. When it fails on GTK it fails like this: > > --- > /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/ > webrtc/ephemeral-certificates-and-cnames-expected.txt > +++ > /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/ > webrtc/ephemeral-certificates-and-cnames-actual.txt > @@ -1,3 +1,7 @@ > +CONSOLE MESSAGE: addIceCandidate error: OperationError: Error processing > ICE candidate > +CONSOLE MESSAGE: Unhandled Promise Rejection: Error: assert_unreached: > Reached unreachable code > + > +Harness Error (FAIL), message = assert_unreached: Reached unreachable code > > PASS Ensuring certificates and cnames are ephemerals This should be handled by https://bugs.webkit.org/show_bug.cgi?id=229931

Note You need to log in before you can comment on or make changes to this bug.