Bug 229757

Summary: Implement libwebrtc network manager GetMdnsResponder
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, crzwdjk, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230021
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Rebasing
none
Rebasing none

Description youenn fablet 2021-09-01 03:35:03 PDT
Implement libwebrtc network manager GetMdnsResponder.
This allows to integrate mDNS handling directly in libwebrtc backend
Comment 1 youenn fablet 2021-09-01 04:42:25 PDT
Created attachment 437014 [details]
Patch
Comment 2 youenn fablet 2021-09-01 04:55:29 PDT
Created attachment 437016 [details]
Patch
Comment 3 youenn fablet 2021-09-01 04:59:37 PDT
Created attachment 437017 [details]
Patch
Comment 4 youenn fablet 2021-09-01 06:21:00 PDT
Created attachment 437023 [details]
Patch
Comment 5 youenn fablet 2021-09-01 06:28:45 PDT
Created attachment 437024 [details]
Patch
Comment 6 youenn fablet 2021-09-01 06:47:25 PDT
Created attachment 437025 [details]
Patch
Comment 7 youenn fablet 2021-09-01 07:05:45 PDT
Created attachment 437026 [details]
Patch
Comment 8 youenn fablet 2021-09-01 11:31:55 PDT
Created attachment 437046 [details]
Patch
Comment 9 youenn fablet 2021-09-01 13:23:48 PDT
Created attachment 437063 [details]
Patch
Comment 10 youenn fablet 2021-09-02 00:00:42 PDT
Created attachment 437117 [details]
Patch
Comment 11 youenn fablet 2021-09-05 23:39:14 PDT
Created attachment 437388 [details]
Rebasing
Comment 12 youenn fablet 2021-09-05 23:40:41 PDT
Created attachment 437389 [details]
Rebasing
Comment 13 EWS 2021-09-06 01:49:10 PDT
Committed r282054 (241354@main): <https://commits.webkit.org/241354@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437389 [details].
Comment 14 Radar WebKit Bug Importer 2021-09-06 01:50:21 PDT
<rdar://problem/82786787>
Comment 15 Arcady Goldmints-Orlov 2021-09-07 13:03:29 PDT
Looks like this has caused the test webrtc/ephemeral-certificates-and-cnames.html to become flaky, I think on all platforms. When it fails on GTK it fails like this:

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/webrtc/ephemeral-certificates-and-cnames-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/webrtc/ephemeral-certificates-and-cnames-actual.txt
@@ -1,3 +1,7 @@
+CONSOLE MESSAGE: addIceCandidate error: OperationError: Error processing ICE candidate
+CONSOLE MESSAGE: Unhandled Promise Rejection: Error: assert_unreached: Reached unreachable code
+
+Harness Error (FAIL), message = assert_unreached: Reached unreachable code
 
 PASS Ensuring certificates and cnames are ephemerals
Comment 16 youenn fablet 2021-09-08 00:08:59 PDT
(In reply to Arcady Goldmints-Orlov from comment #15)
> Looks like this has caused the test
> webrtc/ephemeral-certificates-and-cnames.html to become flaky, I think on
> all platforms. When it fails on GTK it fails like this:
> 
> ---
> /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/
> webrtc/ephemeral-certificates-and-cnames-expected.txt
> +++
> /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/
> webrtc/ephemeral-certificates-and-cnames-actual.txt
> @@ -1,3 +1,7 @@
> +CONSOLE MESSAGE: addIceCandidate error: OperationError: Error processing
> ICE candidate
> +CONSOLE MESSAGE: Unhandled Promise Rejection: Error: assert_unreached:
> Reached unreachable code
> +
> +Harness Error (FAIL), message = assert_unreached: Reached unreachable code
>  
>  PASS Ensuring certificates and cnames are ephemerals

This should be handled by https://bugs.webkit.org/show_bug.cgi?id=229931