Summary: | Implement libwebrtc network manager GetMdnsResponder | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | annulen, cdumez, crzwdjk, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=230021 | ||||||||||||||||||||||||||||
Attachments: |
|
Description
youenn fablet
2021-09-01 03:35:03 PDT
Created attachment 437014 [details]
Patch
Created attachment 437016 [details]
Patch
Created attachment 437017 [details]
Patch
Created attachment 437023 [details]
Patch
Created attachment 437024 [details]
Patch
Created attachment 437025 [details]
Patch
Created attachment 437026 [details]
Patch
Created attachment 437046 [details]
Patch
Created attachment 437063 [details]
Patch
Created attachment 437117 [details]
Patch
Created attachment 437388 [details]
Rebasing
Created attachment 437389 [details]
Rebasing
Committed r282054 (241354@main): <https://commits.webkit.org/241354@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437389 [details]. Looks like this has caused the test webrtc/ephemeral-certificates-and-cnames.html to become flaky, I think on all platforms. When it fails on GTK it fails like this: --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/webrtc/ephemeral-certificates-and-cnames-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/webrtc/ephemeral-certificates-and-cnames-actual.txt @@ -1,3 +1,7 @@ +CONSOLE MESSAGE: addIceCandidate error: OperationError: Error processing ICE candidate +CONSOLE MESSAGE: Unhandled Promise Rejection: Error: assert_unreached: Reached unreachable code + +Harness Error (FAIL), message = assert_unreached: Reached unreachable code PASS Ensuring certificates and cnames are ephemerals (In reply to Arcady Goldmints-Orlov from comment #15) > Looks like this has caused the test > webrtc/ephemeral-certificates-and-cnames.html to become flaky, I think on > all platforms. When it fails on GTK it fails like this: > > --- > /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/ > webrtc/ephemeral-certificates-and-cnames-expected.txt > +++ > /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/ > webrtc/ephemeral-certificates-and-cnames-actual.txt > @@ -1,3 +1,7 @@ > +CONSOLE MESSAGE: addIceCandidate error: OperationError: Error processing > ICE candidate > +CONSOLE MESSAGE: Unhandled Promise Rejection: Error: assert_unreached: > Reached unreachable code > + > +Harness Error (FAIL), message = assert_unreached: Reached unreachable code > > PASS Ensuring certificates and cnames are ephemerals This should be handled by https://bugs.webkit.org/show_bug.cgi?id=229931 |