| Summary: | Non-unified build partial fixes, late late August 2021 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||||
| Component: | New Bugs | Assignee: | Lauro Moura <lmoura> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aperez, calvaris, cdumez, changseok, dpino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, japhet, jer.noble, keith_miller, mark.lam, mifenton, msaboff, philipj, saam, sergio, tommyw, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Lauro Moura
2021-08-31 14:45:55 PDT
Created attachment 436948 [details]
Patch
Comment on attachment 436948 [details]
Patch
Waiting for EWS before CQ+'ing.
Comment on attachment 436948 [details]
Patch
Needs rebase.
Created attachment 436950 [details]
Rebased patch
Comment on attachment 436950 [details]
Rebased patch
Note to self: Remember "--review" in Unreviewed patches...
Created attachment 436951 [details]
Link issue build log
There is still a strange link error about some WebCore symbols missing from WebCoreTestSupport.a when linking lib/libTestRunnerInjectedBundle.so:
For example (full error attached):
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::createRecorderMockSource(WebCore::MediaStreamPrivate&, WebCore::MediaRecorderPrivateOptions const&): error: undefined reference to 'WebCore::MediaRecorderPrivateMock::MediaRecorderPrivateMock(WebCore::MediaStreamPrivate&)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::InspectorStubFrontend::closeWindow(): error: undefined reference to 'WebCore::InspectorFrontendClientLocal::inspectedPage() const'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::InspectorStubFrontend::InspectorStubFrontend(WebCore::Page&, WTF::RefPtr<WebCore::DOMWindow, WTF::RawPtrTraits<WebCore::DOMWindow>, WTF::DefaultRefDerefTraits<WebCore::DOMWindow> >&&): error: undefined reference to 'vtable for WebCore::InspectorFrontendClientLocal::Settings'
/usr/lib/gcc/x86_64-unknown-linux-gnu/10.2.0/../../../../x86_64-unknown-linux-gnu/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::InspectorStubFrontend::InspectorStubFrontend(WebCore::Page&, WTF::RefPtr<WebCore::DOMWindow, WTF::RawPtrTraits<WebCore::DOMWindow>, WTF::DefaultRefDerefTraits<WebCore::DOMWindow> >&&): error: undefined reference to 'WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal(WebCore::InspectorController*, WebCore::Page*, std::unique_ptr<WebCore::InspectorFrontendClientLocal::Settings, std::default_delete<WebCore::InspectorFrontendClientLocal::Settings> >)'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::Internals::initializeMockMediaSource(): error: undefined reference to 'WebCore::MockMediaPlayerMediaSource::registerMediaEngine(void (*)(std::unique_ptr<WebCore::MediaPlayerFactory, std::default_delete<WebCore::MediaPlayerFactory> >&&))'
lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o):Internals.cpp:function WebCore::Internals::parseDoViCodecParameters(WTF::StringView): error: undefined reference to 'WebCore::parseDoViCodecParameters(WTF::StringView)'
Committed r281837 (241170@main): <https://commits.webkit.org/241170@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436950 [details]. |