Bug 229722

Summary:	ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData)
Product:	WebKit	Reporter:	ayumi_kojima
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	achristensen, ryanhaddad, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Mac (Apple Silicon)
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=229505 https://bugs.webkit.org/show_bug.cgi?id=223750

ayumi_kojima

Reported 2021-08-31 10:41:01 PDT

security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement.html Is flaky crashing on macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS. The crash is not seen in the open source directory: https://results.webkit.org/?suite=layout-tests&test=security%2FcontentSecurityPolicy%2Fplugins-types-blocks-youtube-plugin-replacement.html Result page: https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r436856-10911/results.html It looks like the test started showing up as a flaky test at https://ews-build.webkit.org/#/builders/60/builds/10746 Crash log: ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData) ./rendering/RenderLayerCompositor.cpp(1164) : void WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer *, WebCore::RenderLayer &, WebCore::LayerOverlapMap &, WebCore::RenderLayerCompositor::CompositingState &, WebCore::RenderLayerCompositor::BackingSharingState &, bool &) 1 0x1359573ac WTFCrash 2 0x115502c80 WTFCrashWithInfo(int, char const*, char const*, int) 3 0x118df6df4 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::LayerOverlapMap&, WebCore::RenderLayerCompositor::CompositingState&, WebCore::RenderLayerCompositor::BackingSharingState&, bool&) 4 0x118df6af0 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::LayerOverlapMap&, WebCore::RenderLayerCompositor::CompositingState&, WebCore::RenderLayerCompositor::BackingSharingState&, bool&) 5 0x118df6b68 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::LayerOverlapMap&, WebCore::RenderLayerCompositor::CompositingState&, WebCore::RenderLayerCompositor::BackingSharingState&, bool&) 6 0x118df4cb8 WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*) 7 0x118df4308 WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout() 8 0x11820cdc0 WebCore::FrameView::updateCompositingLayersAfterStyleChange() 9 0x11721a914 WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType) 10 0x11721b5cc WebCore::Document::updateStyleIfNeeded() 11 0x117216644 WebCore::Document::updateLayout() 12 0x117217c00 WebCore::Document::updateLayoutIgnorePendingStylesheets(WebCore::Document::RunPostLayoutTasks) 13 0x116dfcf94 WebCore::ComputedStyleExtractor::propertyValue(WebCore::CSSPropertyID, WebCore::EUpdateLayout) 14 0x116dfcdb4 WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue(WebCore::CSSPropertyID, WebCore::EUpdateLayout) const 15 0x116dfbfb8 WebCore::CSSComputedStyleDeclaration::getPropertyValue(WebCore::CSSPropertyID) const 16 0x116e18d40 WebCore::CSSComputedStyleDeclaration::getPropertyValueInternal(WebCore::CSSPropertyID) 17 0x116f17ee0 WebCore::CSSStyleDeclaration::propertyValueForCamelCasedIDLAttribute(WTF::AtomString const&) 18 0x1149dbea0 WebCore::jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttributeGetter(JSC::JSGlobalObject&, WebCore::JSCSSStyleDeclaration&, JSC::PropertyName) 19 0x114946144 long long WebCore::IDLAttribute<WebCore::JSCSSStyleDeclaration>::getPassingPropertyName<&(WebCore::jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttributeGetter(JSC::JSGlobalObject&, WebCore::JSCSSStyleDeclaration&, JSC::PropertyName)), (WebCore::CastedThisErrorBehavior)3>(JSC::JSGlobalObject&, long long, JSC::PropertyName) 20 0x11494601c WebCore::jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttribute(JSC::JSGlobalObject*, long long, JSC::PropertyName) 21 0x1378b97cc JSC::PropertySlot::customGetter(JSC::VM&, JSC::PropertyName) const 22 0x1370f758c JSC::PropertySlot::getValue(JSC::JSGlobalObject*, JSC::PropertyName) const 23 0x1370f9138 JSC::JSValue::get(JSC::JSGlobalObject*, JSC::PropertyName, JSC::PropertySlot&) const 24 0x13729f9e4 JSC::LLInt::performLLIntGetByID(JSC::Instruction const*, JSC::CodeBlock*, JSC::JSGlobalObject*, JSC::JSValue, JSC::Identifier const&, JSC::GetByIdModeMetadata&) 25 0x13729f744 llint_slow_path_get_by_id 26 0x136190c6c llint_entry 27 0x1361aa97c llint_entry 28 0x1361aaa24 llint_entry 29 0x136185964 vmEntryToJavaScript 30 0x1370ed484 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 31 0x1370edae0 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) com.apple.WebKit.WebContent.Development terminated (pid 98101) because the process crashed LEAK: 1 WebPageProxy

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-08-31 10:55:03 PDT

<rdar://problem/82586829>

Simon Fraser (smfr)

Comment 2 2021-08-31 11:08:07 PDT

Please just skip any "youtube-plugin-replacement" tests. This is dead code.

Simon Fraser (smfr)

Comment 3 2021-08-31 11:09:07 PDT

Also bug 223750 and bug 229505 cover the same assertion. No need to file new ones.

ayumi_kojima

Comment 4 2021-08-31 11:14:35 PDT

I just noticed that this assertion is a duplicate of the bugs that you mentioned. Will mark the expectations. Thanks!

ayumi_kojima

Comment 5 2021-08-31 11:36:12 PDT

Updated expectations to skip the test on all platforms in bug 229505

ayumi_kojima

Comment 6 2021-08-31 11:36:23 PDT

*** This bug has been marked as a duplicate of bug 229505 ***

Note You need to log in before you can comment on or make changes to this bug.