Bug 229712

Summary: [contributors.json] Replace class=bot with status=bot
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229690
Attachments:
Description Flags
Patch
none
Patch none

Description Jonathan Bedard 2021-08-31 08:09:52 PDT
Separating class from bot makes generalizing contributors.json difficult. Given that none of our bots declare themselves to be committers or reviewers, we should just replace instances of class=bot with status=bot so we don't have an extra variable.
Comment 1 Radar WebKit Bug Importer 2021-08-31 08:12:48 PDT
<rdar://problem/82579767>
Comment 2 Jonathan Bedard 2021-08-31 08:16:41 PDT
Created attachment 436885 [details]
Patch
Comment 3 Aakash Jain 2021-08-31 08:23:38 PDT
Comment on attachment 436885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436885&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:252
> +            elif data.get('status') == 'bot':

data.get('status') => status
Comment 4 Jonathan Bedard 2021-08-31 08:35:22 PDT
Created attachment 436886 [details]
Patch
Comment 5 EWS 2021-08-31 09:11:44 PDT
Committed r281806 (241142@main): <https://commits.webkit.org/241142@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436886 [details].