Bug 229700

Summary: Migrate to latest libwebrtc AddIceCandidate
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, kkinnunen, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229877
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description youenn fablet 2021-08-31 01:20:33 PDT 
Migrate to latest libwebrtc AddIceCandidate
Comment 1 youenn fablet 2021-08-31 01:21:26 PDT 
Created attachment 436853 [details]
Patch
Comment 2 youenn fablet 2021-08-31 01:44:33 PDT 
Created attachment 436855 [details]
Patch
Comment 3 youenn fablet 2021-08-31 04:52:25 PDT 
Created attachment 436875 [details]
Patch
Comment 4 EWS 2021-09-03 02:41:02 PDT 
Committed r281981 (241288@main): <https://commits.webkit.org/241288@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436875 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-03 02:42:17 PDT 
<rdar://problem/82715667>
Comment 6 Kimmo Kinnunen 2021-09-03 05:29:56 PDT 
This might have caused linking problems:

git grep addIceCandidateFailed 

Source/WebCore/ChangeLog:        (WebCore::PeerConnectionBackend::addIceCandidateFailed): Deleted.
...
Source/WebCore/Modules/mediastream/PeerConnectionBackend.h:    void addIceCandidateFailed(Exception&&);
Comment 7 youenn fablet 2021-09-03 06:25:17 PDT 
(In reply to Kimmo Kinnunen from comment #6)
> This might have caused linking problems:
> 
> git grep addIceCandidateFailed 
> 
> Source/WebCore/ChangeLog:       
> (WebCore::PeerConnectionBackend::addIceCandidateFailed): Deleted.
> ...
> Source/WebCore/Modules/mediastream/PeerConnectionBackend.h:    void
> addIceCandidateFailed(Exception&&);

Thanks, will fix shortly.