Bug 229700

Summary: Migrate to latest libwebrtc AddIceCandidate
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, kkinnunen, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229877
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2021-08-31 01:20:33 PDT
Migrate to latest libwebrtc AddIceCandidate
Attachments
Patch (12.03 KB, patch)
2021-08-31 01:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (28.70 KB, patch)
2021-08-31 01:44 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (29.79 KB, patch)
2021-08-31 04:52 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-08-31 01:21:26 PDT
Created attachment 436853 [details] Patch
youenn fablet
Comment 2 2021-08-31 01:44:33 PDT
Created attachment 436855 [details] Patch
youenn fablet
Comment 3 2021-08-31 04:52:25 PDT
Created attachment 436875 [details] Patch
EWS
Comment 4 2021-09-03 02:41:02 PDT
Committed r281981 (241288@main): <https://commits.webkit.org/241288@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436875 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-03 02:42:17 PDT
<rdar://problem/82715667>
Kimmo Kinnunen
Comment 6 2021-09-03 05:29:56 PDT
This might have caused linking problems: git grep addIceCandidateFailed Source/WebCore/ChangeLog: (WebCore::PeerConnectionBackend::addIceCandidateFailed): Deleted. ... Source/WebCore/Modules/mediastream/PeerConnectionBackend.h: void addIceCandidateFailed(Exception&&);
youenn fablet
Comment 7 2021-09-03 06:25:17 PDT
(In reply to Kimmo Kinnunen from comment #6) > This might have caused linking problems: > > git grep addIceCandidateFailed > > Source/WebCore/ChangeLog: > (WebCore::PeerConnectionBackend::addIceCandidateFailed): Deleted. > ... > Source/WebCore/Modules/mediastream/PeerConnectionBackend.h: void > addIceCandidateFailed(Exception&&); Thanks, will fix shortly.
Note You need to log in before you can comment on or make changes to this bug.