Bug 229671

Summary: [ BigSur arm64 EWS ] ASSERTION FAILED: !needsLayout() ./rendering/RenderView.cpp(305) : virtual void WebCore::RenderView::paint(WebCore::PaintInfo &, const WebCore::LayoutPoint &)
Product: WebKit Reporter: ayumi_kojima
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: ben_schwartz, bfulgham, sabouhallawa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac (Apple Silicon)   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229820
https://bugs.webkit.org/show_bug.cgi?id=230105
https://bugs.webkit.org/show_bug.cgi?id=230113
https://bugs.webkit.org/show_bug.cgi?id=230588
https://bugs.webkit.org/show_bug.cgi?id=241265
Attachments:
Description Flags
Crash log none

ayumi_kojima
Reported 2021-08-30 09:29:57 PDT
imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-img-auto.html Is flaky crashing on macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS. The test seems to have became flaky at this build: https://ews-build.webkit.org/#/builders/60/builds/10617 In the open source directory, the test crashed one time on BigSur AS wk2 Debug: https://build.webkit.org/#/builders/103/builds/2730 History: https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-img-auto.html Result page: https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r436490-10617-rerun/results.html Crash log: ASSERTION FAILED: !needsLayout() ./rendering/RenderView.cpp(305) : virtual void WebCore::RenderView::paint(WebCore::PaintInfo &, const WebCore::LayoutPoint &) 1 0x13738ca3c WTFCrash 2 0x117536140 WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11aa7d58c WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&) 4 0x11a9105c8 WebCore::RenderLayer::paintBackgroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*) 5 0x11a90cf20 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) 6 0x11a92e990 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_24::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const 7 0x11a92e394 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*) 8 0x11a92f66c WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 9 0x11a1ce1b8 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 10 0x11a290308 WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 11 0x117a7afb8 WebCore::PlatformCALayer::drawLayerContents(WebCore::GraphicsContext&, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, unsigned int) 12 0x11a2d6bfc WebCore::TileGrid::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int) 13 0x117c03978 -[WebSimpleLayer drawInContext:] 14 0x19ee037ac CABackingStoreUpdate_ 15 0x19ee604b4 invocation function for block in CA::Layer::display_() 16 0x19ee02a34 -[CALayer _display] 17 0x117c036bc -[WebSimpleLayer display] 18 0x19ee01b2c CA::Layer::display_if_needed(CA::Transaction*) 19 0x19ef2db64 CA::Context::commit_transaction(CA::Transaction*, double, double*) 20 0x19ede3ab8 CA::Transaction::commit() 21 0x19b4b8470 __62+[CATransaction(NSCATransaction) NS_setFlushesWithDisplayLink]_block_invoke 22 0x19bc0d23c ___NSRunLoopObserverCreateWithHandler_block_invoke 23 0x198b4dcc8 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ 24 0x198b4db14 __CFRunLoopDoObservers 25 0x198b4d05c __CFRunLoopRun 26 0x198b4c5e8 CFRunLoopRunSpecific 27 0x1998f5688 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 28 0x199987b70 -[NSRunLoop(NSRunLoop) run] 29 0x1987c3768 _xpc_objc_main 30 0x1987c2f94 xpc_main 31 0x103c5e854 WebKit::XPCServiceMain(int, char const**) com.apple.WebKit.WebContent.Development terminated (pid 64635) because the process crashed LEAK: 8 WebPageProxy
Attachments
Crash log (86.93 KB, text/plain)
2021-08-30 09:30 PDT, ayumi_kojima 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
ayumi_kojima
Comment 1 2021-08-30 09:30:37 PDT
Created attachment 436782 [details] Crash log
Radar WebKit Bug Importer
Comment 2 2021-08-30 09:31:03 PDT
<rdar://problem/82531732>
ayumi_kojima
Comment 3 2021-08-30 09:37:13 PDT
Updated test expectations https://trac.webkit.org/changeset/281763/webkit
ayumi_kojima
Comment 4 2021-08-30 16:33:23 PDT
I was not able to reproduce the crash on BigSur AS using: run-webkit-tests --iterations 50 --exit-after-n-crashes-or-timeouts 1 --no-build --clobber-old-results --debug imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-img-auto.html.
ayumi_kojima
Comment 5 2021-08-30 16:43:45 PDT
Iterated 500 times, but I was not able to reproduce the crash.
ayumi_kojima
Comment 6 2021-08-30 16:49:27 PDT
Used --force for reproduction, but, I wasn't able to reproduce the crash.
Ben Schwartz
Comment 7 2024-05-29 17:07:06 PDT
This no longer appears to be occurring. Removing test expectations. Please file a new bug if issues persist.
EWS
Comment 8 2024-05-29 17:16:30 PDT
Test gardening commit 279477@main (b3257b764978): <https://commits.webkit.org/279477@main> Reviewed commits have been landed. Closing PR #29266 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.