Bug 229640

Summary: The CSS Font Loading API shouldn't be able to delete a CSS-connected font
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, sam, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229850    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Myles C. Maxfield
Reported 2021-08-27 22:57:50 PDT
The CSS Font Loading API can't delete a CSS-connected font
Attachments
Patch (3.90 KB, patch)
2021-08-27 23:01 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2021-08-28 15:27 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (4.46 KB, patch)
2021-09-01 02:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-08-27 23:01:26 PDT
Created attachment 436706 [details] Patch
Sam Weinig
Comment 2 2021-08-28 11:20:00 PDT
Comment on attachment 436706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436706&action=review > LayoutTests/ChangeLog:9 > + * fast/text/FontFaceSet-delete-css-connected-expected.html: Added. > + * fast/text/FontFaceSet-delete-css-connected.html: Added. Seems a little odd to use a ref test for something that uses shouldBe(). Usually we do dumpAsText() I think. What's the motivation here? > LayoutTests/fast/text/FontFaceSet-delete-css-connected-expected.html:11 > +self.enablePixelTesting = true; What's this line do?
Myles C. Maxfield
Comment 3 2021-08-28 11:25:48 PDT
Comment on attachment 436706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436706&action=review >> LayoutTests/fast/text/FontFaceSet-delete-css-connected-expected.html:11 >> +self.enablePixelTesting = true; > > What's this line do? It stops js-test.js from calling dumpAsText(). The motivation is I want to test both the JS checks, and the fact that the text is rendered with Ahem after the JS executes.
Myles C. Maxfield
Comment 4 2021-08-28 11:37:28 PDT
Comment on attachment 436706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436706&action=review >>> LayoutTests/fast/text/FontFaceSet-delete-css-connected-expected.html:11 >>> +self.enablePixelTesting = true; >> >> What's this line do? > > It stops js-test.js from calling dumpAsText(). > > The motivation is I want to test both the JS checks, and the fact that the text is rendered with Ahem after the JS executes. I guess I can split this into 2 tests.
Myles C. Maxfield
Comment 5 2021-08-28 15:27:41 PDT
Created attachment 436724 [details] Patch
Myles C. Maxfield
Comment 6 2021-09-01 02:54:16 PDT
Created attachment 437007 [details] Patch
EWS
Comment 7 2021-09-02 20:14:58 PDT
Committed r281975 (241282@main): <https://commits.webkit.org/241282@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437007 [details].
Radar WebKit Bug Importer
Comment 8 2021-09-02 20:15:27 PDT
<rdar://problem/82706378>
Note You need to log in before you can comment on or make changes to this bug.