| Summary: | The CSS Font Loading API shouldn't be able to delete a CSS-connected font | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, sam, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 229850 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2021-08-27 22:57:50 PDT
Created attachment 436706 [details]
Patch
Comment on attachment 436706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436706&action=review > LayoutTests/ChangeLog:9 > + * fast/text/FontFaceSet-delete-css-connected-expected.html: Added. > + * fast/text/FontFaceSet-delete-css-connected.html: Added. Seems a little odd to use a ref test for something that uses shouldBe(). Usually we do dumpAsText() I think. What's the motivation here? > LayoutTests/fast/text/FontFaceSet-delete-css-connected-expected.html:11 > +self.enablePixelTesting = true; What's this line do? Comment on attachment 436706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436706&action=review >> LayoutTests/fast/text/FontFaceSet-delete-css-connected-expected.html:11 >> +self.enablePixelTesting = true; > > What's this line do? It stops js-test.js from calling dumpAsText(). The motivation is I want to test both the JS checks, and the fact that the text is rendered with Ahem after the JS executes. Comment on attachment 436706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436706&action=review >>> LayoutTests/fast/text/FontFaceSet-delete-css-connected-expected.html:11 >>> +self.enablePixelTesting = true; >> >> What's this line do? > > It stops js-test.js from calling dumpAsText(). > > The motivation is I want to test both the JS checks, and the fact that the text is rendered with Ahem after the JS executes. I guess I can split this into 2 tests. Created attachment 436724 [details]
Patch
Created attachment 437007 [details]
Patch
Committed r281975 (241282@main): <https://commits.webkit.org/241282@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437007 [details]. |