Bug 229557

Summary: [GTK] EventSenderProxyGtk does not implement touch event synthesis
Product: WebKit Reporter: Chris Lord <clord>
Component: Tools / TestsAssignee: Chris Lord <clord>
Status: NEW ---    
Severity: Normal CC: aperez, berto, cgarcia, ews-watchlist, gustavo, hi, mcatanzaro, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229998
Attachments:
Description Flags
Patch
none
Patch clord: review?

Description Chris Lord 2021-08-26 08:13:10 PDT 
As the bug title says.

This and the combination of the wheel-event synthesis API not letting you specify if precise scroll events are present makes it impossible to test the behaviour of precise (e.g. touch/touchpad) scrolling on GTK. While the easiest fix for that would be to add an extra prototype for specifying hasPreciseScrollDeltas to the wheel-event synthesis API, I think implementing touch event synthesis is the nicer and more flexible way of doing this, given that API already exists, is implemented on basically every other platform and is currently just stubbed.
Comment 1 Chris Lord 2021-09-06 09:31:22 PDT 
Created attachment 437421 [details]
Patch
Comment 2 Chris Lord 2021-09-06 09:33:45 PDT 
I've not re-baselined/enabled tests in this patch yet, I'm hoping EWS makes it easier for me to determine the list of tests that will need changing/re-enabling.
Comment 3 EWS Watchlist 2021-09-06 16:26:50 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Chris Lord 2021-09-07 06:38:07 PDT 
Created attachment 437495 [details]
Patch
Comment 5 Carlos Garcia Campos 2021-09-13 00:57:55 PDT 
Comment on attachment 437495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437495&action=review

> LayoutTests/platform/gtk/TestExpectations:-590
> -# These tests require touch support
> -fast/events/touch [ Skip ]
> -imported/w3c/web-platform-tests/touch-events [ Skip ]

I'm surprised we can unskip these, we enable touch support at runtime depending on the hardware, or did that change?