Bug 229552

Summary: Remove all WTR output before Content-Type:text/plain for WebRTC tests on BigSur
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230733
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2021-08-26 05:57:41 PDT
Remove all WTR output before Content-Type:text/plain for WebRTC tests
Comment 2 youenn fablet 2021-08-26 06:01:41 PDT
Created attachment 436502 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-08-26 07:52:38 PDT
<rdar://problem/82390178>
Comment 4 Jonathan Bedard 2021-08-30 10:27:07 PDT
Comment on attachment 436502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436502&action=review

> Tools/Scripts/webkitpy/port/driver.py:126
> +            if re.match(detector, result[0]):

This is a pretty large change, do we know if any of our existing detector strings are actually regexes? If the goal is to just string all logging, we could add the empty string to logging_detectors, in python `'' in 'some string'` is always true.
Comment 5 youenn fablet 2021-09-02 23:58:19 PDT
Created attachment 437247 [details]
Patch
Comment 6 EWS 2021-09-03 06:28:12 PDT
Committed r281988 (241295@main): <https://commits.webkit.org/241295@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437247 [details].