Bug 229534

Summary:

Add more support for JIT operation validation testing.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, benjamin, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, keith_miller, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	ews-feeder: commit-queue-
proposed patch.	ews-feeder: commit-queue-
proposed patch.	none
proposed patch.	saam: review+

Mark Lam

Reported 2021-08-25 20:57:51 PDT

rdar://81526335

Attachments
proposed patch. (232.05 KB, patch) 2021-08-25 21:18 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
proposed patch. (233.52 KB, patch) 2021-08-25 21:28 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
proposed patch. (233.58 KB, patch) 2021-08-25 22:48 PDT, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch. (232.50 KB, patch) 2021-08-31 19:23 PDT, Mark Lam	saam: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2021-08-25 21:18:43 PDT

Created attachment 436463 [details] proposed patch. Let's try this on the EWS.

Mark Lam

Comment 2 2021-08-25 21:28:39 PDT

Created attachment 436465 [details] proposed patch.

Mark Lam

Comment 3 2021-08-25 22:48:22 PDT

Created attachment 436474 [details] proposed patch.

Mark Lam

Comment 4 2021-08-31 19:23:24 PDT

Created attachment 436985 [details] proposed patch.

Saam Barati

Comment 5 2021-09-01 18:00:21 PDT

Comment on attachment 436985 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=436985&action=review r=me > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:404 > g_jscConfig.startExecutableMemory = tagCodePtr<ExecutableMemoryPtrTag>(reservation.base); > g_jscConfig.endExecutableMemory = tagCodePtr<ExecutableMemoryPtrTag>(reservationEnd); why not remove these, and switch everyone to using some nice standalone functions that return g_config[0] and g_config[1]? > Source/bmalloc/bmalloc/GigacageConfig.h:107 > +constexpr size_t startSlotOfGigacageConfig = 2; maybe it's worth commenting somewhere that the first 2 slots are for the executable bounds?

Mark Lam

Comment 6 2021-09-01 18:28:30 PDT

(In reply to Saam Barati from comment #5) > Comment on attachment 436985 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=436985&action=review > > r=me > > > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:404 > > g_jscConfig.startExecutableMemory = tagCodePtr<ExecutableMemoryPtrTag>(reservation.base); > > g_jscConfig.endExecutableMemory = tagCodePtr<ExecutableMemoryPtrTag>(reservationEnd); > > why not remove these, and switch everyone to using some nice standalone > functions that return g_config[0] and g_config[1]? I'll try to do this in a separate follow up patch (since this one is already so big). > > Source/bmalloc/bmalloc/GigacageConfig.h:107 > > +constexpr size_t startSlotOfGigacageConfig = 2; > > maybe it's worth commenting somewhere that the first 2 slots are for the > executable bounds? I'll add a comment saying that the first 2 slots are reserve for the use of the ExecutableAllocator.

Mark Lam

Comment 7 2021-09-02 00:21:30 PDT

Thanks for the review. Landed in r281910: <http://trac.webkit.org/r281910>.

Note You need to log in before you can comment on or make changes to this bug.