Bug 229525

Summary: Web Inspector: Rename `ContextualDocumentation*` to `CSSDocumentation` to reduce path length and improve code readability
Product: WebKit Reporter: Patrick Angle <pangle>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1.0
none
Patch v1.1
none
Patch v1.2 - Rebaseline none

Patrick Angle
Reported 2021-08-25 15:36:23 PDT
<rdar://82334145>
Attachments
Patch v1.0 (352.72 KB, patch)
2021-08-25 16:10 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.1 (379.18 KB, patch)
2021-08-25 16:41 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.2 - Rebaseline (380.75 KB, patch)
2021-08-26 13:22 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick Angle
Comment 1 2021-08-25 16:10:22 PDT
Created attachment 436435 [details] Patch v1.0
Patrick Angle
Comment 2 2021-08-25 16:32:34 PDT
The impetus for this change is that `ContextualDocumentationDatabase.js` is not copyable in some Windows build environments due to file path 254 character limit being exceeded. Renaming bug to better describe the work actually being done in this patch.
Patrick Angle
Comment 3 2021-08-25 16:41:30 PDT
Created attachment 436439 [details] Patch v1.1
Joseph Pecoraro
Comment 4 2021-08-25 16:48:04 PDT
(In reply to Patrick Angle from comment #2) > The impetus for this change is that `ContextualDocumentationDatabase.js` is > not copyable in some Windows build environments due to file path 254 > character limit being exceeded. Yikes! I feel like this is a much bigger problem if true. :/
Patrick Angle
Comment 5 2021-08-26 13:22:00 PDT
Created attachment 436557 [details] Patch v1.2 - Rebaseline
Devin Rousso
Comment 6 2021-08-26 14:22:45 PDT
Comment on attachment 436557 [details] Patch v1.2 - Rebaseline r=me
EWS
Comment 7 2021-08-26 15:32:48 PDT
Committed r281663 (241016@main): <https://commits.webkit.org/241016@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436557 [details].
Note You need to log in before you can comment on or make changes to this bug.