Bug 229498

Summary: [git-webkit] Use Python 3 in CI
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225929
https://bugs.webkit.org/show_bug.cgi?id=229574
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2021-08-25 09:02:30 PDT
Although git-webkit supports Python 2, it's a Python 3 script and should be invoked as such. A previous attempt to do this was effected by https://bugs.webkit.org/show_bug.cgi?id=229172, which has now been resolved
Attachments
Patch (5.01 KB, patch)
2021-08-25 09:07 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.05 KB, patch)
2021-08-25 11:08 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-25 09:06:19 PDT
<rdar://problem/82342387>
Jonathan Bedard
Comment 2 2021-08-25 09:07:07 PDT
Created attachment 436394 [details] Patch
Jonathan Bedard
Comment 3 2021-08-25 11:08:31 PDT
Created attachment 436404 [details] Patch
Aakash Jain
Comment 4 2021-08-25 12:32:13 PDT
Comment on attachment 436404 [details] Patch I applied this patch on ews uat instance and tested in https://ews-build.webkit-uat.org/#/builders/35/builds/106357 Hopefully we wouldn't see any unexpected issue this time.
Jonathan Bedard
Comment 5 2021-08-25 12:36:43 PDT
(In reply to Aakash Jain from comment #4) > Comment on attachment 436404 [details] > Patch > > I applied this patch on ews uat instance and tested in > https://ews-build.webkit-uat.org/#/builders/35/builds/106357 > > Hopefully we wouldn't see any unexpected issue this time. The issue last time had to do with the auto installer, which I fixed as part of run-webkit-tests moving to Python 3.
EWS
Comment 6 2021-08-25 14:18:23 PDT
Committed r281586 (240950@main): <https://commits.webkit.org/240950@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436404 [details].
Aakash Jain
Comment 7 2021-08-26 10:40:40 PDT
buildbot on build.webkit.org has been restarted to pick up this change.
Aakash Jain
Comment 8 2021-08-27 04:19:45 PDT
buildbot on EWS has been restarted to pick up this change.
Jonathan Bedard
Comment 9 2022-03-09 10:46:01 PST
*** Bug 222045 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.