Summary: | [ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ayumi_kojima | ||||
Component: | New Bugs | Assignee: | Patrick Angle <pangle> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, hi, pangle, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Mac (Intel) | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
ayumi_kojima
2021-08-24 11:35:53 PDT
It seems like the test has been flaky since it was introduced here https://trac.webkit.org/changeset/281323/webkit Updated test expectations https://trac.webkit.org/changeset/281507/webkit I think the timing in this test is too tight since we need to receive the message from the test WebSocket server while paused for debugging in the test. I'll tweak the timing. Created attachment 436470 [details]
Patch v1.0
Comment on attachment 436470 [details]
Patch v1.0
Manually verified locally that 1000 iterations pass with `run-webkit-tests --iterations=1000 --exit-after-n-crashes-or-timeouts=1 --exit-after-n-failures=1 LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html`
Comment on attachment 436470 [details]
Patch v1.0
rs=me
Committed r281658 (241011@main): <https://commits.webkit.org/241011@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436470 [details]. |