Bug 229446

Summary:

[ iOS ] TestWebKitAPI.DocumentEditingContext.Request* tests are failing

Product:

WebKit

Reporter:

ayumi_kojima

Component:

New Bugs

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description ayumi_kojima 2021-08-24 09:27:37 PDT

TestWebKitAPI.DocumentEditingContext.RequestLastLine
TestWebKitAPI.DocumentEditingContext.RequestLastTwoLines
TestWebKitAPI.DocumentEditingContext.RequestFirstTwoLines
TestWebKitAPI.DocumentEditingContext.RequestFirstLine

Are failing on iOS.

History https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.DocumentEditingContext.RequestLastLine&test=TestWebKitAPI.DocumentEditingContext.RequestFirstLine&test=TestWebKitAPI.DocumentEditingContext.RequestFirstTwoLines&test=TestWebKitAPI.DocumentEditingContext.RequestLastTwoLines

Diffs:

TestWebKitAPI.DocumentEditingContext.RequestFirstLine

/Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:1287
Expected equality of these values:
"The first sentence in the first paragraph"
(NSString *)context.contextAfter
Which is: "The first sentence in the first paragraph. The second sentence in the first paragraph. The third sentence in the first paragraph."

TestWebKitAPI.DocumentEditingContext.RequestFirstTwoLines

/Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:1300
Expected equality of these values:
"The first sentence in the first paragraph. The second sentence in"
(NSString *)context.contextAfter
Which is: "The first sentence in the first paragraph. The second sentence in the first paragraph. The third sentence in the first paragraph.\nThe first sentence in the second paragraph. The second sentence in the second paragraph. The third sentence in the second paragraph."
With diff:
@@ -1,1 +1,2 @@
-The first sentence in the first paragraph. The second sentence in
+The first sentence in the first paragraph. The second sentence in the first paragraph. The third sentence in the first paragraph.
+The first sentence in the second paragraph. The second sentence in the second paragraph. The third sentence in the second paragraph.

TestWebKitAPI.DocumentEditingContext.RequestLastLine

/Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:1311
Expected equality of these values:
"third sentence in the third paragraph."
(NSString *)context.contextBefore
Which is: "The first sentence in the third paragraph. The second sentence in the third paragraph. The third sentence in the third paragraph."

TestWebKitAPI.DocumentEditingContext.RequestLastTwoLines

/Volumes/Data/worker/ios-simulator-14-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:1324
Expected equality of these values:
"in the third paragraph. The third sentence in the third paragraph."
(NSString *)context.contextBefore
Which is: "The first sentence in the second paragraph. The second sentence in the second paragraph. The third sentence in the second paragraph.\nThe first sentence in the third paragraph. The second sentence in the third paragraph. The third sentence in the third paragraph."
With diff:
@@ -1,1 +1,2 @@
-in the third paragraph. The third sentence in the third paragraph.
+The first sentence in the second paragraph. The second sentence in the second paragraph. The third sentence in the second paragraph.
+The first sentence in the third paragraph. The second sentence in the third paragraph. The third sentence in the third paragraph.

Comment 1 Radar WebKit Bug Importer 2021-08-24 09:28:13 PDT

<rdar://problem/82295496>

Comment 2 zalan 2021-08-24 14:01:33 PDT

Created attachment 436327 [details]
Patch

Comment 3 zalan 2021-08-24 19:44:30 PDT

The queue for the api-ios is 9hours long. :( landing this now.

Comment 4 EWS 2021-08-24 20:07:25 PDT

Committed r281542 (240909@main): <https://commits.webkit.org/240909@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436327 [details].