Bug 229405

Summary:

RemoteGraphicsContextGL refers to GraphicsContextGLOpenGL::SimulatedEventForTesting

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

WebGL

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, kbr, kkinnunen, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

229404

Attachments:

Description	Flags
Patch	none

Description Kimmo Kinnunen 2021-08-23 03:49:40 PDT

RemoteGraphicsContextGL refers to GraphicsContextOpenGL::SimulatedEventForTesting

SimulatedEventForTesting is defined in the base class GraphicsContextGL.

Using GraphicsContextOpenGL is problematic in case we try to move the ANGLE implementation out from GraphicsContextOpenGL.

Comment 1 Kimmo Kinnunen 2021-08-23 03:52:53 PDT

Created attachment 436179 [details]
Patch

Comment 2 Kenneth Russell 2021-08-23 18:07:15 PDT

Comment on attachment 436179 [details]
Patch

Looks good. r+

Comment 3 EWS 2021-08-26 05:30:53 PDT

Committed r281620 (240976@main): <https://commits.webkit.org/240976@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436179 [details].

Comment 4 Radar WebKit Bug Importer 2021-08-26 05:31:19 PDT

<rdar://problem/82385242>

Comment 5 Kimmo Kinnunen 2022-09-15 01:23:44 PDT

Re-opening for pull request https://github.com/WebKit/WebKit/pull/4374

Comment 6 EWS 2022-09-28 01:12:11 PDT

Committed 254947@main (d257ea20c599): <https://commits.webkit.org/254947@main>

Reviewed commits have been landed. Closing PR #4374 and removing active labels.