WebGL calls into static GraphicsContextGLOpenGL functions needlessly

• Component: WebGL
• Status: RESOLVED FIXED

[Kimmo Kinnunen]

WebGL calls into static GraphicsContextGLOpenGL functions needlessly

The calls are problematic:
* No other call sites than WebGL layer 
* The functionality is not needed for ANGLE, but present
* GraphicsContextGL is now an interface with multiple implementations, GraphicsContextGLOpenGL is just one implementation

[Kimmo Kinnunen]

Created attachment 436178 [details]
Patch

[Kimmo Kinnunen]

Created attachment 436184 [details]
Patch

[Kimmo Kinnunen]

Created attachment 436185 [details]
Patch

[Kenneth Russell]

Comment on attachment 436185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436185&action=review

Looks good in principle; I didn't look into the failures on the platforms not yet using ANGLE. Hopefully they won't be hard to figure out. r+

> Source/WebCore/html/canvas/WebGLFramebuffer.cpp:409
> +#endif

Now might be a good time to add comments to the #endifs like:

#endif // !USE(ANGLE)

because it's hard to see what it matches up with once these blocks span multiple lines of code.

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:639
>  #endif

Please consider commenting the #endifs to make them easier to read.

[Kimmo Kinnunen]

Created attachment 436373 [details]
Patch for landing

[EWS]

Committed r281621 (240977@main): <https://commits.webkit.org/240977@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436373 [details].

[Radar WebKit Bug Importer]

<rdar://problem/82385595>