Bug 229371

Summary: [JSC] Remove Intl runtime feature flags for already shipped ones
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2021-08-21 14:25:21 PDT
[JSC] Remove Intl runtime feature flags for already shipped ones
Attachments
Patch (10.71 KB, patch)
2021-08-21 14:25 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.38 KB, patch)
2021-08-21 14:28 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-08-21 14:25:55 PDT
Created attachment 436084 [details] Patch
Yusuke Suzuki
Comment 2 2021-08-21 14:28:03 PDT
Created attachment 436085 [details] Patch
Ross Kirsling
Comment 3 2021-08-21 14:43:38 PDT
Comment on attachment 436085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436085&action=review r=me with a comment > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Remove Intl runtime feature flags for already shipped ones Seems like this should be retitled since there's exactly one.
Yusuke Suzuki
Comment 4 2021-08-21 16:39:57 PDT
Comment on attachment 436085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436085&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] Remove Intl runtime feature flags for already shipped ones > > Seems like this should be retitled since there's exactly one. Ah, there are two flags useIntlDateTimeFormatDayPeriod and useIntlDateTimeFormatRangeToParts :)
EWS
Comment 5 2021-08-21 17:27:01 PDT
Committed r281383 (240798@main): <https://commits.webkit.org/240798@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436085 [details].
Radar WebKit Bug Importer
Comment 6 2021-08-21 17:28:17 PDT
<rdar://problem/82208868>
Note You need to log in before you can comment on or make changes to this bug.