Bug 229357

Summary:

[macOS] getDisplayMedia should capture at the constrained size if possible

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebRTC

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=229868

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none

Eric Carlson

Reported 2021-08-20 16:49:08 PDT

Give getDisplayMedia classes enough information to capture at the constrained size if possible, instead of always capturing at the device size and resizing.

Attachments
Patch (23.30 KB, patch) 2021-08-23 09:38 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (24.16 KB, patch) 2021-09-01 09:29 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing (24.91 KB, patch) 2021-09-01 12:55 PDT, Eric Carlson	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (25.50 KB, patch) 2021-09-01 13:21 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-08-20 16:49:28 PDT

<rdar://problem/82191109>

Eric Carlson

Comment 2 2021-08-23 09:38:18 PDT

Created attachment 436205 [details] Patch This won't apply without the changes in https://bugs.webkit.org/show_bug.cgi?id=229142

Eric Carlson

Comment 3 2021-09-01 09:29:49 PDT

Created attachment 437037 [details] Patch

youenn fablet

Comment 4 2021-09-01 11:22:55 PDT

Comment on attachment 437037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437037&action=review > Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h:57 > + const IntSize intrinsicSize() const final; s/const// here and elsewhere

Eric Carlson

Comment 5 2021-09-01 12:55:02 PDT

Created attachment 437057 [details] Patch for landing

Darin Adler

Comment 6 2021-09-01 13:00:38 PDT

Comment on attachment 437037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437037&action=review >> Source/WebCore/platform/mediastream/mac/CGDisplayStreamScreenCaptureSource.h:57 >> + const IntSize intrinsicSize() const final; > > s/const// here and elsewhere The first const, the one that needlessly makes the return value const, not the one after the function name.

Eric Carlson

Comment 7 2021-09-01 13:21:54 PDT

Created attachment 437061 [details] Patch for landing

EWS

Comment 8 2021-09-01 14:49:12 PDT

Committed r281880 (241210@main): <https://commits.webkit.org/241210@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437061 [details].

Note You need to log in before you can comment on or make changes to this bug.