Bug 229356

Summary: Use the strongly typed PageGroupIdentifier in place of uint64_t
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit2Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, kkinnunen, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
achristensen: review+, ews-feeder: commit-queue-
Patch none

Description Simon Fraser (smfr) 2021-08-20 16:30:05 PDT
Use the strongly typed PageGroupIdentifier in place of uint64_t
Comment 1 Simon Fraser (smfr) 2021-08-20 16:31:40 PDT
Created attachment 436041 [details]
Patch
Comment 2 Alex Christensen 2021-08-20 16:34:45 PDT
Comment on attachment 436041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436041&action=review

> Source/WebKit/WebProcess/WebPage/WebPageGroupProxy.h:48
> +    // Namespace IDs for local storage namespaces are equivalent to web page group IDs.

I would update this to "currently equivalent" because I think we intend to change this once we completely remove WebPageGroup/WebPageGroupProxy.

> Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h:56
> +    // Namespace IDs for local storage namespaces are equivalent to web page group IDs.

ditto
Comment 3 Simon Fraser (smfr) 2021-08-20 16:38:35 PDT
Created attachment 436042 [details]
Patch
Comment 4 EWS 2021-08-22 08:36:00 PDT
Committed r281398 (240806@main): <https://commits.webkit.org/240806@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436042 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-22 08:36:18 PDT
<rdar://problem/82218164>