Bug 229342

Summary: [git-webkit] Forward unknown args to log and blame
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, andresg_22, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-08-20 11:34:50 PDT
git-webkit log and git-webkit blame do not correctly forward options that begin with '-' as an artifact of Python's argparser. As the below example shows, that can be a problem: git blame -L1474,1484 Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
Attachments
Patch (3.29 KB, patch)
2021-08-20 11:37 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.83 KB, patch)
2021-08-20 11:50 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.54 KB, patch)
2021-08-20 14:24 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-20 11:36:24 PDT
<rdar://problem/82178743>
Jonathan Bedard
Comment 2 2021-08-20 11:37:38 PDT
Created attachment 436011 [details] Patch
Jonathan Bedard
Comment 3 2021-08-20 11:39:47 PDT
Comment on attachment 436011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436011&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py:87 > + parsed = parser.parse_args(args=args) Open to other thoughts here, but in general, if the command in question doesn't have args, we want to parse it normally. If it does have args, we want to treat all unknown values as args. The trouble is, we can't figure out which case we're in until we parse the command in the first place.
Jonathan Bedard
Comment 4 2021-08-20 11:50:56 PDT
Created attachment 436014 [details] Patch
Aakash Jain
Comment 5 2021-08-20 13:15:25 PDT
Comment on attachment 436014 [details] Patch rs=me
Jonathan Bedard
Comment 6 2021-08-20 14:24:13 PDT
Created attachment 436029 [details] Patch for landing
EWS
Comment 7 2021-08-20 14:57:07 PDT
Committed r281339 (240756@main): <https://commits.webkit.org/240756@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436029 [details].
Note You need to log in before you can comment on or make changes to this bug.