Bug 22933

Summary: make RenderBlock::columnGap() public
Product: WebKit Reporter: Cary Clark <caryclark>
Component: PlatformAssignee: Cary Clark <caryclark>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
This patch makes RenderBlock::columnGap() public. darin: review+

Cary Clark
Reported 2008-12-19 06:45:31 PST
ANDROID creates an array of focus rectangles for navigation with a trackball or directional pad, and needs access to the column gap to implement this logic.
Attachments
This patch makes RenderBlock::columnGap() public. (1.42 KB, patch)
2008-12-19 06:50 PST, Cary Clark 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cary Clark
Comment 1 2008-12-19 06:50:16 PST
Created attachment 26142 [details] This patch makes RenderBlock::columnGap() public.
Darin Adler
Comment 2 2008-12-24 23:09:34 PST
Comment on attachment 26142 [details] This patch makes RenderBlock::columnGap() public. r=me This is only a stopgap measure, though. Until the code to make an array of focus rectangles is somewhere in the WebKit repository, there's a good chance someone will make this private again. It's not part of any public interface, and when researching they won't look at code that's not checked in here.
Eric Seidel (no email)
Comment 3 2009-02-04 16:31:40 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderBlock.h Committed r40646
Note You need to log in before you can comment on or make changes to this bug.