Bug 229329

Summary: Remove assertIsTagged and assertIsNullOrTagged.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2021-08-20 02:30:13 PDT
These assertion utility functions relies on tagged pointers always having non-zero PAC bits. This is an incorrect assumption. A tagged pointer can have PAC bits that are completely zero. Hence, these assert functions cannot be made to work reliably. We should remove them to prevent them from being used, and potentially resulting in flaky assertion failures that will hard to debug later.
Attachments
proposed patch. (2.72 KB, patch)
2021-08-20 02:45 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-20 02:30:40 PDT
<rdar://problem/82162851>
Mark Lam
Comment 2 2021-08-20 02:45:09 PDT
Created attachment 435963 [details] proposed patch.
Yusuke Suzuki
Comment 3 2021-08-20 02:50:57 PDT
Comment on attachment 435963 [details] proposed patch. r=me
Mark Lam
Comment 4 2021-08-20 08:25:05 PDT
Comment on attachment 435963 [details] proposed patch. Thanks for the review. Landing now.
EWS
Comment 5 2021-08-20 08:53:22 PDT
Committed r281317 (240734@main): <https://commits.webkit.org/240734@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435963 [details].
Note You need to log in before you can comment on or make changes to this bug.