Bug 229328

Summary: Make ptrTagName and tagForPtr WTF_EXPORT_PRIVATE.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Description Mark Lam 2021-08-20 02:04:57 PDT 
If ptrTagName and tagForPtr are defined, make them WTF_EXPORT_PRIVATE instead of static functions.  This allows us to call them from the debugger during interactive debugging sessions.
Comment 1 Mark Lam 2021-08-20 02:09:17 PDT 
Created attachment 435956 [details]
proposed patch.
Comment 2 Radar WebKit Bug Importer 2021-08-20 02:09:48 PDT 
<rdar://problem/82162395>
Comment 3 Yusuke Suzuki 2021-08-20 02:16:42 PDT 
Comment on attachment 435956 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2021-08-20 08:24:12 PDT 
Comment on attachment 435956 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2021-08-20 08:56:14 PDT 
Committed r281318 (240735@main): <https://commits.webkit.org/240735@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435956 [details].