Decoding webm file with more than 2 channels will fail

• Component: Web Audio
• Status: NEW ---

[Jean-Yves Avenard [:jya]]

Decoding of webm with more than 2 channels will fail with a decoding error.

STR:
1- Open https://jyavenard.github.io/htmltests/tests/webaudio/decodeAudioData.html
2- Select opus-mapping2.webm in the drop down list
3- press play

Result: will show a decoding error as context.decodeAudioData return an error

[Radar WebKit Bug Importer]

<rdar://problem/82160691>

[Jean-Yves Avenard [:jya]]

Created attachment 437580 [details]
Patch

[Eric Carlson]

Comment on attachment 437580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437580&action=review

> Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:175
> +        setVorbisChannelMap(layout, cookie.channelCount);

Why do you set the *Vorbis* channel map with an Opus cookie? A comment would be helpful.

[Jean-Yves Avenard [:jya]]

Comment on attachment 437580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437580&action=review

> Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:176
> +        m_channelLayout = layout;

https://datatracker.ietf.org/doc/html/rfc7845#section-5.1.1.2

mapping family one uses the vorbis layout.

[Eric Carlson]

Comment on attachment 437580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437580&action=review

>> Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:176
>> +        m_channelLayout = layout;
> 
> https://datatracker.ietf.org/doc/html/rfc7845#section-5.1.1.2
> 
> mapping family one uses the vorbis layout.

Yes, my point is that someone unfamiliar with the RFC may be confused by code so a comment would be helpful.

[Derk-Jan Hartman]

This problem still exists:
Example: https://upload.wikimedia.org/wikipedia/commons/d/d3/Elephants_Dream_%282006%29.120p.vp9.opus.multichannel.webm

No downsampling occurs and video playback fails. Because canPlayType passes, no fallback can occur to another source (like webm vp8, vorbis) either, creating a broken experience for the user.

This is unfortunate as multichannel is supported by the format and it means that for Wikimedia we will now have to downsample all our derivatives/transcodes to stereo, if we do not want such files to break on macOS. This denies users of Chrome and Firefox the benefit of proper multichannel sound.

Last tested on Safari 15.4 and STP 142, macOS 12.3 on a MacBook Pro from 2021.
Wikimedia ticket: https://phabricator.wikimedia.org/T304624

[Jean-Yves Avenard [:jya]]

(In reply to Derk-Jan Hartman from comment #6)
> This problem still exists:
> Example:
> https://upload.wikimedia.org/wikipedia/commons/d/d3/
> Elephants_Dream_%282006%29.120p.vp9.opus.multichannel.webm
> 

It still exists because it hasn’t been fixed. 

The framework decoder unfortunately lacks the ability to decode more than 2 channels file

[Alexey Proskuryakov]

*** Bug 241220 has been marked as a duplicate of this bug. ***