Make UIEventAttribution tests less platform dependent

• Component: New Bugs
• Status: RESOLVED FIXED

[Alex Christensen]

Make UIEventAttribution tests less platform dependent

[Alex Christensen]

Created attachment 435943 [details]
Patch

[John Wilander]

TestWebKitAPI.EventAttribution.Basic is timing out on iOS.

[John Wilander]

Comment on attachment 435943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435943&action=review

r=me as long as the broken iOS test is fixed.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:58
> +- (void)_addEventAttributionWithSourceID:(uint8_t)sourceID destinationURL:(NSURL *)destination sourceDescription:(NSString *)sourceDescription purchaser:(NSString *)purchaser reportEndpoint:(NSURL *)reportEndpoint nonce:(NSString *)nonce

Should we call the nonce parameter optionalNonce?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:265
> +    [webView _addEventAttributionWithSourceID:42 destinationURL:exampleURL() sourceDescription:@"test source description" purchaser:@"test purchaser" reportEndpoint:serverURL nonce:@"ABCDEFabcdef0123456789"];

Where did 42 come from? Did it come from MockEventAttribution before?

[Alex Christensen]

This test seems to have been timing out since r277447, which was refactored significantly in r279514

[Alex Christensen]

Created attachment 436034 [details]
Patch

[Alex Christensen]

Comment on attachment 436034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436034&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:129
> +#if HAVE(UI_EVENT_ATTRIBUTION)

I verified on Monterey that this is not needed.  The test is no longer dependent on UIEventAttribution.

[Alex Christensen]

http://trac.webkit.org/r281349

[Radar WebKit Bug Importer]

<rdar://problem/82189489>