| Summary: | [build.webkit.org] GTK-Linux-64-bit-Release-Skip-Failing-Tests worker should run only layout tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, bugs-noreply, clopez, jbedard, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=229311 | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Alberto Lopez Perez
2021-08-19 17:13:31 PDT
Created attachment 435930 [details]
Patch
Comment on attachment 435930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review > Tools/CISupport/build-webkit-org/factories.py:218 > +class TestLayoutFactory(Factory): Nit: better to call it LayoutTestFactory (even though the naming might not be good earlier, we can improve it now) Comment on attachment 435930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435930&action=review > Tools/CISupport/build-webkit-org/factories.py:225 > + self.addStep(RunDashboardTests()) Do you want to run dashboard tests on this queue? (In reply to Aakash Jain from comment #2) > Comment on attachment 435930 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435930&action=review > > > Tools/CISupport/build-webkit-org/factories.py:218 > > +class TestLayoutFactory(Factory): > > Nit: better to call it LayoutTestFactory (even though the naming might not > be good earlier, we can improve it now) That would be inconsistent with the other factory naming.. all are named either "TestSomethingFactory" or "BuildAndTestSomethingFactory" (In reply to Aakash Jain from comment #3) > Comment on attachment 435930 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435930&action=review > > > Tools/CISupport/build-webkit-org/factories.py:225 > > + self.addStep(RunDashboardTests()) > > Do you want to run dashboard tests on this queue? I think we do, for consistency, as far as I can see the dashboard tests runner simply calls run-webkit-tests over other directory than LayoutTests. So they seem to me like some kind of specialized layout tests. Committed r281327 (240744@main): <https://commits.webkit.org/240744@main> buildbot was restarted to pick up this change. Seems to be working, e.g.: https://build.webkit.org/#/builders/199/builds/951 |