Bug 229288

Summary:

[run-webkit-tests] Handle json crash logs

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dewei_zhu, ews-watchlist, glenn, ryanhaddad, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Jonathan Bedard 2021-08-19 08:30:05 PDT

Starting in Monterey, .ips crash logs are JSON encoded in macOS.  run-webkit-tests needs to handle this.

Comment 1 Jonathan Bedard 2021-08-19 08:30:22 PDT

<rdar://problem/77074039>

Comment 2 Jonathan Bedard 2021-08-19 08:33:08 PDT

Created attachment 435861 [details]
Patch

Comment 3 Jonathan Bedard 2021-08-19 08:55:35 PDT

Created attachment 435864 [details]
Patch

Comment 4 Alexey Proskuryakov 2021-08-19 09:22:40 PDT

This code would benefit from unit testing, as we want to support multiple format and multiple kinds of logs (distinguishing crashes and sandbox violations).

Comment 5 Jonathan Bedard 2021-08-19 11:39:52 PDT

Created attachment 435888 [details]
Patch

Comment 6 Jonathan Bedard 2021-08-19 11:41:42 PDT

(In reply to Jonathan Bedard from comment #5)
> Created attachment 435888 [details]
> Patch

Added a json crash log to our unit testing.

Comment 7 EWS 2021-08-19 12:46:08 PDT

Committed r281257 (240692@main): <https://commits.webkit.org/240692@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435888 [details].