Bug 229278

Summary: Replace the uint64_t used to identify taps with an ObjectIdentifier<> type
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: UI EventsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229302, 229308    
Attachments:
Description Flags
Patch
wenson_hsieh: review+, wenson_hsieh: commit-queue-
Patch none

Simon Fraser (smfr)
Reported 2021-08-18 20:43:53 PDT
Replace the uint64_t used to identify taps with an ObjectIdentifier<> type
Attachments
Patch (42.56 KB, patch)
2021-08-18 20:46 PDT, Simon Fraser (smfr) 		wenson_hsieh: review+
wenson_hsieh: commit-queue-
DetailsFormatted DiffDiff
Patch (42.44 KB, patch)
2021-08-19 11:01 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-08-18 20:46:08 PDT
Created attachment 435837 [details] Patch
Wenson Hsieh
Comment 2 2021-08-18 20:55:46 PDT
Comment on attachment 435837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435837&action=review r=me once this is rebased on trunk > Source/WebKit/Shared/IdentifierTypes.h:34 > + Nice. This seems like a good place to put the various other identifier types used in WebKit2 that are currently just in their own headers, but we can do that later. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3113 > + Nit - stray newline here.
Simon Fraser (smfr)
Comment 3 2021-08-19 11:01:53 PDT
Created attachment 435884 [details] Patch
EWS
Comment 4 2021-08-19 15:48:33 PDT
Committed r281276 (240701@main): <https://commits.webkit.org/240701@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435884 [details].
Radar WebKit Bug Importer
Comment 5 2021-08-19 15:49:17 PDT
<rdar://problem/82145392>
Note You need to log in before you can comment on or make changes to this bug.