| Summary: | Do not terminate relaunched network process when getting network process connection | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||
| Component: | WebKit Misc. | Assignee: | Sihui Liu <sihui_liu> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, cdumez, ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sihui Liu
2021-08-18 09:15:50 PDT
Created attachment 435774 [details]
Patch
Comment on attachment 435774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435774&action=review > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1762 > + if (networkProcessProxy && networkProcessProxy.get() == strongThis->m_networkProcess.get()) Do we really need the ".get()" on either side? It should be OK to == RefPtrs. Comment on attachment 435774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435774&action=review >> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1762 >> + if (networkProcessProxy && networkProcessProxy.get() == strongThis->m_networkProcess.get()) > > Do we really need the ".get()" on either side? It should be OK to == RefPtrs. It seems we only need one .get(), will update. Created attachment 435781 [details]
Patch for landing
Committed r281199 (240643@main): <https://commits.webkit.org/240643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435781 [details]. |