Bug 229236

Summary: Do not terminate relaunched network process when getting network process connection
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: WebKit Misc.Assignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2021-08-18 09:15:50 PDT
...
Attachments
Patch (3.65 KB, patch)
2021-08-18 09:27 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.66 KB, patch)
2021-08-18 10:19 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2021-08-18 09:27:31 PDT
Created attachment 435774 [details] Patch
Chris Dumez
Comment 2 2021-08-18 09:53:15 PDT
Comment on attachment 435774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435774&action=review > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1762 > + if (networkProcessProxy && networkProcessProxy.get() == strongThis->m_networkProcess.get()) Do we really need the ".get()" on either side? It should be OK to == RefPtrs.
Sihui Liu
Comment 3 2021-08-18 10:18:15 PDT
Comment on attachment 435774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435774&action=review >> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1762 >> + if (networkProcessProxy && networkProcessProxy.get() == strongThis->m_networkProcess.get()) > > Do we really need the ".get()" on either side? It should be OK to == RefPtrs. It seems we only need one .get(), will update.
Sihui Liu
Comment 4 2021-08-18 10:19:27 PDT
Created attachment 435781 [details] Patch for landing
EWS
Comment 5 2021-08-18 10:45:36 PDT
Committed r281199 (240643@main): <https://commits.webkit.org/240643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435781 [details].
Radar WebKit Bug Importer
Comment 6 2021-08-18 10:46:18 PDT
<rdar://problem/82084469>
Note You need to log in before you can comment on or make changes to this bug.