Bug 229200

Summary: REGRESSION (iOS 15): DoubleDown Casino app won't load past launch page
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: CanvasAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, mmaxfield, sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS none

Description Wenson Hsieh 2021-08-17 12:45:44 PDT
rdar://81636256
Comment 1 Wenson Hsieh 2021-08-17 13:45:29 PDT
Created attachment 435712 [details]
For EWS
Comment 2 Myles C. Maxfield 2021-08-17 16:33:09 PDT
Comment on attachment 435712 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=435712&action=review

> Source/WebKit/ChangeLog:43
> +        Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).

Ideally a new test would be good, but I think it's evident that this is already tested by existing tests, which are currently flakey now.
Comment 3 Wenson Hsieh 2021-08-17 16:37:01 PDT
Comment on attachment 435712 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=435712&action=review

Thanks for the review!

(Let's wait for ios-wk2 before adding the cq+)

>> Source/WebKit/ChangeLog:43
>> +        Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).
> 
> Ideally a new test would be good, but I think it's evident that this is already tested by existing tests, which are currently flakey now.

Indeed — I'm still actively working on a layout test for this.
I suspect that figuring out how to trigger the race conditions that cause this bug will also help us write more tests in this area, moving forward.
Comment 4 Wenson Hsieh 2021-08-17 19:46:01 PDT
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 435712 [details]
> For EWS
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435712&action=review
> 
> Thanks for the review!
> 
> (Let's wait for ios-wk2 before adding the cq+)
> 
> >> Source/WebKit/ChangeLog:43
> >> +        Unfortunately, I have not been able to come up with a layout test that reliably reproduces this scenario (yet).
> > 
> > Ideally a new test would be good, but I think it's evident that this is already tested by existing tests, which are currently flakey now.
> 
> Indeed — I'm still actively working on a layout test for this.
> I suspect that figuring out how to trigger the race conditions that cause
> this bug will also help us write more tests in this area, moving forward.

(Tracking a test in https://bugs.webkit.org/show_bug.cgi?id=229222)
Comment 5 Wenson Hsieh 2021-08-18 06:32:33 PDT
Comment on attachment 435712 [details]
For EWS

Looks like iOS test failures are unrelated.
Comment 6 EWS 2021-08-18 06:42:55 PDT
Committed r281186 (240631@main): <https://commits.webkit.org/240631@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435712 [details].