| Summary: | Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ehutchison, ews-watchlist, glenn, jbedard, jenner, ryanhaddad, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=230733 | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2021-08-17 05:53:27 PDT
Created attachment 435681 [details]
Patch
Comment on attachment 435681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435681&action=review > Tools/Scripts/webkitpy/port/mac.py:-299 > - Why are you deleting these? Comment on attachment 435681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435681&action=review >> Tools/Scripts/webkitpy/port/mac.py:-299 >> - > > Why are you deleting these? They should be covered by Negotiation String and LRP which signal encoder is doing some logging. These additional lines were attempts to cover the fact encoder logging is being wrapped in multiple lines, but as we see, it does not work well. Committed r281297 (240721@main): <https://commits.webkit.org/240721@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435681 [details]. *** Bug 225525 has been marked as a duplicate of this bug. *** As can be seen in https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r280628%20(4289)/webrtc/video-setDirection-pretty-diff.html, this is not covering all cases: the underlying codec related logging is sometimes half captured. One possibility would be to remove all logging before Content-Type:text/plain in all webrtc tests. *** Bug 225523 has been marked as a duplicate of this bug. *** |