Bug 229188

Summary: Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ehutchison, ews-watchlist, glenn, jbedard, jenner, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230733
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2021-08-17 05:53:27 PDT
Remove all WTR output before Content-Type:text/plain for WebRTC tests in case of known excessive logging
Attachments
Patch (5.69 KB, patch)
2021-08-17 06:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-08-17 06:05:28 PDT
Created attachment 435681 [details] Patch
Jonathan Bedard
Comment 2 2021-08-17 10:17:35 PDT
Comment on attachment 435681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435681&action=review > Tools/Scripts/webkitpy/port/mac.py:-299 > - Why are you deleting these?
youenn fablet
Comment 3 2021-08-18 00:52:35 PDT
Comment on attachment 435681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435681&action=review >> Tools/Scripts/webkitpy/port/mac.py:-299 >> - > > Why are you deleting these? They should be covered by Negotiation String and LRP which signal encoder is doing some logging. These additional lines were attempts to cover the fact encoder logging is being wrapped in multiple lines, but as we see, it does not work well.
EWS
Comment 4 2021-08-20 00:50:26 PDT
Committed r281297 (240721@main): <https://commits.webkit.org/240721@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435681 [details].
Radar WebKit Bug Importer
Comment 5 2021-08-20 00:51:15 PDT
<rdar://problem/82160516>
youenn fablet
Comment 6 2021-08-20 09:16:20 PDT
*** Bug 225525 has been marked as a duplicate of this bug. ***
youenn fablet
Comment 7 2021-08-26 05:45:00 PDT
As can be seen in https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r280628%20(4289)/webrtc/video-setDirection-pretty-diff.html, this is not covering all cases: the underlying codec related logging is sometimes half captured.
youenn fablet
Comment 8 2021-08-26 05:45:45 PDT
One possibility would be to remove all logging before Content-Type:text/plain in all webrtc tests.
Brent Fulgham
Comment 9 2022-02-12 20:40:07 PST
*** Bug 225523 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.