Bug 229161

Summary: Ensure that unused LLInt opcodes are not inadvertently used.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
rmorisset: review+
proposed patch. rmorisset: review+

Mark Lam
Reported 2021-08-16 13:54:26 PDT
Patch coming.
Attachments
proposed patch. (1.12 KB, patch)
2021-08-16 13:57 PDT, Mark Lam 		rmorisset: review+
DetailsFormatted DiffDiff
proposed patch. (2.36 KB, patch)
2021-08-16 15:43 PDT, Mark Lam 		rmorisset: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-08-16 13:57:50 PDT
Created attachment 435628 [details] proposed patch.
Robin Morisset
Comment 2 2021-08-16 14:13:42 PDT
Comment on attachment 435628 [details] proposed patch. r=me
Mark Lam
Comment 3 2021-08-16 15:43:52 PDT
Created attachment 435635 [details] proposed patch.
Robin Morisset
Comment 4 2021-08-16 15:46:04 PDT
Comment on attachment 435635 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=435635&action=review r=me, thanks a lot for the better Changelog! > Source/JavaScriptCore/ChangeLog:27 > + currently emits nothing. As a result, if we ever have a bug that ends up typo: emits -> emit
Mark Lam
Comment 5 2021-08-16 16:12:59 PDT
Thanks for the review. Landed in r281115: <http://trac.webkit.org/r281115>.
Radar WebKit Bug Importer
Comment 6 2021-08-16 16:13:21 PDT
<rdar://problem/82003176>
Note You need to log in before you can comment on or make changes to this bug.